Change close text / done button

[hirbod]

Hi @EddyVerbruggen ,

is it possible to change the "Done" Button text? I know it's not implemented, but prob. possible to implement? Any Ideas? Also, is it possible to "lift it up" on iPad like it does on the iPhone? Is it possible to decide where the "done" button has to be? (on the right side e.g. instead of the left)

I know these are many questions, but I am just asking what my customer was asking :D

Thanks for your support

[jvjvjv]

• "Done" button text. This feature will only be available for iOS 11+.
• Position of button. It doesn't look like this is configurable.

[EddyVerbruggen]

@jvjvjv Can you please link to the doc for that iOS 11+ feature? Thx!

[jayj]

@EddyVerbruggen Here's a link: https://developer.apple.com/documentation/safariservices/sfsafariviewcontroller.dismissbuttonstyle
Looks like it supports "Done", "Close", and "Cancel".

Here's some screenshots from a pdf I found (page 86-90)

[EddyVerbruggen]

Interesting. But it's iOS 11 Beta only for now: https://developer.apple.com/documentation/safariservices/sfsafariviewcontroller.dismissbuttonstyle?changes=latest_minor

[simonwatt]

@EddyVerbruggen Now that iOS 11 is out of beta is it likely that dismissButtonStyle will be added as a configurable option to the plugin?

[EddyVerbruggen]

Anyone up for the challenge?

[jvjvjv]

@EddyVerbruggen @simonwatt Got a deadline on this? I've already created a branch.

[jvjvjv]

Oh goodness. All the errors I'm getting in the XCode project now!
No visible @interface for 'SafariViewController' declares the selector 'getTransitionStyle:'
is one of them. And I keep seeing similar errors for each option. Any ideas why this is happening now?

[simonwatt]

@jvjvjv Did you ever end up having any success with getting this to work?

[nivaldocavalcanti]

I know this is an old question but I hope this might help someone...

I put dismissButton: 1 in options:

SafariViewController.show({
    url: 'http://your-url.com',
    hidden: false, // default false. You can use this to load cookies etc in the background (see issue #1 for details).
    animated: false, // default true, note that 'hide' will reuse this preference (the 'Done' button will always animate though)
    transition: 'slide', // (this only works in iOS 9.1/9.2 and lower) unless animated is false you can choose from: curl, flip, fade, slide (default)
    enterReaderModeIfAvailable: false, // default false
    dismissButton: 1, //0 - Done, 1 - Close, 2 - Cancel
    tintColor: "#00ffff", // default is ios blue
    barColor: "#0000ff", // on iOS 10+ you can change the background color as well
    controlTintColor: "#ffffff" // on iOS 10+ you can override the default tintColor
},
...

And in SafariViewController.m file I put this code below right after vc.delegate = self:

NSNumber *dismissButton = options[@"dismissButton"];
if(dismissButton != nil){
    vc.dismissButtonStyle = [dismissButton intValue];
}

According to @jayj comment and Apple documentation now I can choose Done, Close or Cancel label for dismiss button. =)

I'm using deployment target iOS 12.

[javierjsp]

I know this is an old question but I hope this might help someone...

I put dismissButton: 1 in options:

SafariViewController.show({
    url: 'http://your-url.com',
    hidden: false, // default false. You can use this to load cookies etc in the background (see issue #1 for details).
    animated: false, // default true, note that 'hide' will reuse this preference (the 'Done' button will always animate though)
    transition: 'slide', // (this only works in iOS 9.1/9.2 and lower) unless animated is false you can choose from: curl, flip, fade, slide (default)
    enterReaderModeIfAvailable: false, // default false
    dismissButton: 1, //0 - Done, 1 - Close, 2 - Cancel
    tintColor: "#00ffff", // default is ios blue
    barColor: "#0000ff", // on iOS 10+ you can change the background color as well
    controlTintColor: "#ffffff" // on iOS 10+ you can override the default tintColor
},
...

And in SafariViewController.m file I put this code below right after vc.delegate = self:

NSNumber *dismissButton = options[@"dismissButton"];
if(dismissButton != nil){
    vc.dismissButtonStyle = [dismissButton intValue];
}

According to @jayj comment and Apple documentation now I can choose Done, Close or Cancel label for dismiss button. =)

I'm using deployment target iOS 12.

this should be a pull request, nice @nivaldocavalcanti , and maybe for Ionic developers need to update
index.d.ts on @ionic-native\safari-view-controller\ngx put below url?: string; -> dismissButton?: number; in order to use dismissButton inside the options of .show({}) otherwise a error will show on console because that variable not exist on interface SafariViewControllerOptions

[WuglyakBolgoink]

I put dismissButton: 1 in options:

SafariViewController.show({
    url: 'http://your-url.com',
    hidden: false, // default false. You can use this to load cookies etc in the background (see issue #1 for details).
    animated: false, // default true, note that 'hide' will reuse this preference (the 'Done' button will always animate though)
    transition: 'slide', // (this only works in iOS 9.1/9.2 and lower) unless animated is false you can choose from: curl, flip, fade, slide (default)
    enterReaderModeIfAvailable: false, // default false
    dismissButton: 1, //0 - Done, 1 - Close, 2 - Cancel
    tintColor: "#00ffff", // default is ios blue
    barColor: "#0000ff", // on iOS 10+ you can change the background color as well
    controlTintColor: "#ffffff" // on iOS 10+ you can override the default tintColor
},
...

any progress on this?

[hirbod]

Still people out there using Cordova? 😅

[snblackout]

Still people out there using Cordova? 😅

Unfortunately, yes. LOL Legacy code be damned. We are planning migration to new stuff though. But things still work, so tweaking things here and there makes more sense until a full re-write is completed.