Use proper event handling for activity result on Android #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm.. 🤔good question indeed. Your PR looks great, I'll need some time to test on Android 7 and 8. |
|
Yep, works perfectly fine. Thanks a lot, @mikaelkalt! |
|
You're welcome! Thanks for merging it that fast 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've realised that when using the fingerprint plugin in combination with different plugins on the latest Android 8 that it somehow interferes with the Intent handling. We were using the fingerprint plugin in combination with your barcode plugin and on Android 8 the barcode result was never returned because the
activityResultevent was never thrown. When I was digging in your code I've realised that for some reason you're not using the event handling to get the activityResult instead you're somehow overwriting the method on the main foreground activity. I guess this caused the event propagation to fail. It seems like using the event handling fixes that problem tough I can't really explain why this only happens on Android 8.