To patch the node_modules in platforms folder using after_prepare hook #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @CharlesJu1, I've tested your changes and AFAIK they are rock-solid! The embedded demo app doesn't contain a lot of test-packages, but at least those that I can check work just fine. Thanks for your efforts! I'm publishing 0.6.0 now. |
|
I wonder if this change affects Webpack-builds by the way. I guess we'll learn soon. |
|
As a bonus, this PR seemed to drastically reduce build time (from 10-12 minutes to 2 on our app) |
|
@westlakem It sure does, because fi dev-dependencies and platform-specific files of irrelevant platforms are no longer parsed 🚀. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave it a try to make the plugin patch the node_modules in the platforms folder rather than the source folder. It seems working ok. Here is what I did:
In package.json, change the before_prepare hook to after_prepare hook and points to a new script file called patch_platform.js
In patch_platform.js, require the platform specific patch-npm-packages.js.
In patch-npm-packages.js, on line 227, require the package.json file from the source dir. The code logic is the same as before.