Integration #3
Closed
Integration #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 14, 2017 13:59
…nd router issues still need to be addressed.
…e to avoid problems with possible mis-spellings when used throughout the app.
paullinator
pushed a commit
that referenced
this pull request
Sep 23, 2017
# This is the 1st commit message: Contract full copyable address with ellipsis (...) # This is the commit message #2: Internationalize strings for transactionList scene (sprintf) # This is the commit message #3: More i18n strings for transactionsList scene # This is the commit message #4: Slight adjustments to walletList i18n (sprintf) # This is the commit message #5: i18n text strings on settings overview scene # This is the commit message #6: i18n for settings and currency settings
smilingkylan
added a commit
that referenced
this pull request
Nov 29, 2018
# This is the 1st commit message: Initial creation of 2 Create Account scenes # This is the commit message #2: Implementation of accountSetup scene (Createwallet) # This is the commit message #3: Initial layout for createWalletSelect scene # This is the commit message #4: Initial layout for createWalletAccount review
smilingkylan
added a commit
that referenced
this pull request
Nov 29, 2018
# This is the 1st commit message: Fix merge conflicts # This is the commit message #2: Implement insufficient funds modal for createWalletAccount # This is the commit message #3: Implement insufficient funds modal for createWalletAccount2 # This is the commit message #4: Add strings for error modal (createWalletAccount)2
Closed
Jon-edge
added a commit
that referenced
this pull request
Dec 5, 2025
Test coverage for: - Multi-word search with space delimiter (AND logic) - startsWith matching for currencyCode, displayName, assetDisplayName - includes matching for chainDisplayName, wallet name, contractAddress - assetDisplayName and chainDisplayName only searched for mainnet assets - Regression tests for original issues (#1: 'base eth', #3: 'eth' vs Tether)
Jon-edge
added a commit
that referenced
this pull request
Dec 5, 2025
Test coverage for: - Multi-word search with space delimiter (AND logic) - startsWith matching for currencyCode, displayName, assetDisplayName - includes matching for chainDisplayName, wallet name, contractAddress - assetDisplayName and chainDisplayName only searched for mainnet assets - Regression tests for original issues (#1: 'base eth', #3: 'eth' vs Tether)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers integrating the change pin, change password, password recovery into gui. I also added screen keys as constants to avoid spelling mistakes.