Refactor Fiat Plugin enterAmount API
#4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
changed the title
enterAmount API
paullinator
requested changes
May 16, 2023
src/plugins/gui/amountQuotePlugin.ts
Outdated
| @@ -158,7 +158,7 @@ export const amountQuoteFiatPlugin: FiatPluginFactory = async (params: FiatPlugi | |||
| getMethods: (methods: FiatPluginGetMethodsResponse) => { | |||
| enterAmountMethods = methods | |||
| }, | |||
| convertValue: async (sourceFieldNum: number, value: string): Promise<string | undefined> => { | |||
| onFieldChange: async (sourceFieldNum: number, value: string): Promise<string | undefined> => { | |||
There was a problem hiding this comment.
I would disagree with this rename. The callback NEEDS to do a value conversion. It's not just a generic field change callback
| import { useHandler } from '../../../hooks/useHandler' | ||
| import { useState } from '../../../types/reactHooks' | ||
|
|
||
| export class StateManager<State extends object> { |
There was a problem hiding this comment.
why the class? Why not just instantiate an object within useRef on line 28?
src/plugins/gui/amountQuotePlugin.ts
Outdated
| @@ -157,15 +157,24 @@ export const amountQuoteFiatPlugin: FiatPluginFactory = async (params: FiatPlugi | |||
| }, | |||
| label1: sprintf(lstrings.fiat_plugin_amount_currencycode, displayFiatCurrencyCode), | |||
| label2: sprintf(lstrings.fiat_plugin_amount_currencycode, currencyCode), | |||
| onFieldChange: async (sourceFieldNum, value, stateManager): Promise<string | undefined> => { | |||
| onFieldChange: async (sourceFieldNum, value, stateManager) => { | |||
There was a problem hiding this comment.
Still not sure I like this convention as it makes it "optional" to update the other field.
| const otherFieldKey = sourceFieldNum === 1 ? 'value2' : 'value1' | ||
| const spinnerKey = sourceFieldNum === 1 ? 'spinner2' : 'spinner1' | ||
|
|
||
| stateManager.update({ [spinnerKey]: true }) |
There was a problem hiding this comment.
why is the spinner now getting modified in this callback?
| @@ -129,3 +115,8 @@ export interface FiatPlugin { | |||
| } | |||
|
|
|||
| export type FiatPluginFactory = (params: FiatPluginFactoryArgs) => Promise<FiatPlugin> | |||
|
|
|||
| export interface StatefulSceneEvent<EventValue, State extends object> { | |||
There was a problem hiding this comment.
I won't ask for a change, but not sure what this commit buys us. The syntax for calling the callbacks is more complex. The generics also make the code harder to read.
paullinator
approved these changes
May 17, 2023
samholmes
force-pushed
the
sam/fiat-plugin-refactors
branch
from
19b880f
to
0e803e0
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
enterAmountAPIDependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: