New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is still a crash going on for some pages and I cannot figure... #134

Closed
EdwardHinkle opened this Issue Mar 18, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@EdwardHinkle
Owner

EdwardHinkle commented Mar 18, 2018

There is still a crash going on for some pages and I cannot figure out what’s causing it. Right now the only page I’ve found it on is this one: https://david-smith.org/blank.html

When I try to use the Indigenous Share Extension, it crashes immediately.

(Originally published at: https://eddiehinkle.com/2018/03/17/16/reply/)

@zoglesby

This comment has been minimized.

zoglesby commented Mar 18, 2018

I have seen this on a few websites as well, try an article on The Verge for example.

@EdwardHinkle

This comment has been minimized.

Owner

EdwardHinkle commented Mar 18, 2018

Thanks for confirming that :)

It looks to be something with when a website is not parsable by Xray (the web site parsing service Indigenous uses). I thought I had it failing gracefully, but apparently not!

@EdwardHinkle EdwardHinkle self-assigned this May 9, 2018

@EdwardHinkle EdwardHinkle added this to the 1.0-rc milestone May 9, 2018

@srushe

This comment has been minimized.

srushe commented May 14, 2018

I’ve found that I’m reliably able to recreate the issue with the share sheet using xkcd. If I’m on an xkcd page on the www subdomain then the share sheet disappears after a couple of seconds, whereas when I’m on the bare xkcd.com domain it appears and stays (until dismissed). Your belief that it’s Xray-related definitely looks correct as Xray shows different behaviour for the 2 versions of the domain, finding the data for the bare domain, but failing for the www version.

If nothing else hopefully this makes the issue easier to replicate.

@EdwardHinkle EdwardHinkle modified the milestones: 1.0-rc, 0.3-beta May 15, 2018

@EdwardHinkle

This comment has been minimized.

Owner

EdwardHinkle commented May 15, 2018

Thanks! That’s helpful. This error is a pretty big priority so I’m gonna try to wrap it up in this next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment