Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user agent on HTTP client #83

Merged
merged 7 commits into from Nov 30, 2017

Conversation

Projects
None yet
3 participants
@casz
Copy link
Collaborator

commented Nov 30, 2017

fixes #76

Setting the user agent. @sj26 is this to your liking? 馃憤

User-agent: Bitbucket version: 4.10.2, Post webhook plugin version: 1.6.3-SNAPSHOT

@sj26

This comment has been minimized.

Copy link

commented Nov 30, 2017

Oh neat, yes 鈥 thank you! 馃檱

I had a couple of goes at setting up a dev environment for bitbucket server addons but didn't quite get everything working.

@casz

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 30, 2017

Changes result in the following properties files inside the jar file:

my.plugin.name=Post Webhook Plugin
pluginGroupId=nl.topicus.bitbucket
pluginArtifactId=bitbucket-webhooks
pluginVersion=1.6.3-SNAPSHOT
pluginKey=nl.topicus.bitbucket.bitbucket-webhooks
buildJavaVersion=1.8.0_152
buildTimeStamp=2017-11-30T02:18:39Z

Here is the new user-agent:

Bitbucket version: 4.10.2, Post webhook plugin version: 1.6.3-SNAPSHOT

@casz casz force-pushed the casz:setUserAgent branch from 317d2f3 to b74de07 Nov 30, 2017

@Eernie

Eernie approved these changes Nov 30, 2017

Copy link
Owner

left a comment

馃憦 Great addition 馃憦
LGTM

@casz casz force-pushed the casz:setUserAgent branch from acbbafb to 19085ab Nov 30, 2017

@casz casz merged commit bd3bef8 into Eernie:master Nov 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@casz casz deleted the casz:setUserAgent branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.