Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Fix issue #13 #14

Closed
wants to merge 1 commit into from
Closed

Fix issue #13 #14

wants to merge 1 commit into from

Conversation

cryptofuture
Copy link
Collaborator

@cryptofuture cryptofuture commented Apr 16, 2017

Should fix #13
However needs an extra check on arm and ppc64.
Works for i386

@EggieCode
Copy link
Owner

Maybe note in the changelog Jonathon of the mailing?


override_dh_auto_build-arch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to keep the build phase, in addition to adding the install phase? The two generally should be separate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work without, but its not a problem to add extra line with build-arch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. In that case, then, let's just merge #15 and close this one?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, maybe test it first on a private repo? That not everything crashes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the same and will produce the same result, just #15 more style correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, in that case, can you close this #14, and give your +1 on #15's comments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#wireguard on Freenode, by the way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I can't join right now. I was intended to start work with another project actually... I don't think my help needed on irc anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems like i386 wireguard-tools package is broken
3 participants