-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Maybe note in the changelog Jonathon of the mailing? |
|
||
override_dh_auto_build-arch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you want to keep the build phase, in addition to adding the install phase? The two generally should be separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work without, but its not a problem to add extra line with build-arch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. In that case, then, let's just merge #15 and close this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, maybe test it first on a private repo? That not everything crashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its the same and will produce the same result, just #15 more style correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#wireguard on Freenode, by the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I can't join right now. I was intended to start work with another project actually... I don't think my help needed on irc anyway.
Should fix #13
However needs an extra check on arm and ppc64.
Works for i386