Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix issue #13 #14
Conversation
This comment has been minimized.
This comment has been minimized.
|
Maybe note in the changelog Jonathon of the mailing? |
zx2c4
reviewed
Apr 16, 2017
|
|
||
| override_dh_auto_build-arch: |
This comment has been minimized.
This comment has been minimized.
zx2c4
Apr 16, 2017
Contributor
Maybe you want to keep the build phase, in addition to adding the install phase? The two generally should be separate.
This comment has been minimized.
This comment has been minimized.
cryptofuture
Apr 16, 2017
Author
Collaborator
Should work without, but its not a problem to add extra line with build-arch
This comment has been minimized.
This comment has been minimized.
zx2c4
Apr 16, 2017
Contributor
Alright. In that case, then, let's just merge #15 and close this one?
This comment has been minimized.
This comment has been minimized.
EggieCode
Apr 16, 2017
Owner
Cool, maybe test it first on a private repo? That not everything crashes?
This comment has been minimized.
This comment has been minimized.
cryptofuture
Apr 16, 2017
Author
Collaborator
Its the same and will produce the same result, just #15 more style correct.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cryptofuture
Apr 16, 2017
Author
Collaborator
Sorry, I can't join right now. I was intended to start work with another project actually... I don't think my help needed on irc anyway.
zx2c4
referenced this pull request
Apr 16, 2017
Merged
debian/rules: the tools are arch dependent #15
cryptofuture
closed this
Apr 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cryptofuture commentedApr 16, 2017
•
edited
Should fix #13
However needs an extra check on arm and ppc64.
Works for i386