Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Plugins have to keep requesting priority #63

Closed
wants to merge 1 commit into from

2 participants

Theo Spears Jan
Theo Spears

Previously once a plugin requested priority it would always have it,
now it must be explicitly requested again during every request

Theo Spears Plugins have to keep requesting priority
Previously once a plugin requested priority it would always have it,
now it must be explicitly requested again during every request
91d09a4
Jan

But that is the desired behavior, only to have priority once abd having to request it again

Theo Spears

I think my description of the patch was unclear. The current behaviour of the code is that plugins can continue to have priority, even if they don't keep requesting it. This patch changes the behaviour so they have to keep requesting it.

Jan

Oh :) I'll take a look at it

Jan

I will add this change manually, as I would need to merge it manually, as automerge is not possible :) just one line of code :) so I'll close here and will push a fix in a sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 29, 2012
  1. Plugins have to keep requesting priority

    Theo Spears authored
    Previously once a plugin requested priority it would always have it,
    now it must be explicitly requested again during every request
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  plugin.py
1  plugin.py
View
@@ -135,6 +135,7 @@ def initialize(self, method, speech, language, send_object, send_plist, assistan
self.location = location
self.__match = match
self.__shouldCancel = False
+ self.__priority = False
def _abortPluginRun(self):
self.__shouldCancel = True
Something went wrong with that request. Please try again.