From 0682f12ee6b460a6163c98e0584236bdf07c7578 Mon Sep 17 00:00:00 2001 From: "jgadewar-c@eightfold" Date: Wed, 6 Aug 2025 15:08:45 +0530 Subject: [PATCH] refactor(skillTag): optimize click handler with spread operator --- src/components/Skill/SkillTag.tsx | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/components/Skill/SkillTag.tsx b/src/components/Skill/SkillTag.tsx index 75b86cfb3..0545b1646 100644 --- a/src/components/Skill/SkillTag.tsx +++ b/src/components/Skill/SkillTag.tsx @@ -170,18 +170,16 @@ export const SkillTag: FC = React.forwardRef( >
) => { - if ( - readonly || - disabled || - !clickable || - size === SkillSize.XSmall || - e.target !== e.currentTarget - ) { - return; - } - onClick?.(e); - }} + {...(!readonly && !disabled && clickable && size !== SkillSize.XSmall + ? { + onClick: (e: React.MouseEvent) => { + if (e.target !== e.currentTarget) { + return; + } + onClick?.(e); + }, + } + : {})} style={{ background }} >
{children}