Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck: scope reduction: discord_blist_node_menu: act variable #261

Closed
pabs3 opened this issue Aug 30, 2019 · 1 comment

Comments

@pabs3
Copy link
Contributor

commented Aug 30, 2019

The act variable from the discord_blist_node_menu is only used when the channel variable is not NULL, so its scope can be reduced to the scope created by the not NULL check.

$ cppcheck -j1 --quiet --enable=all .
[libdiscord.c:5589]: (style) The scope of the variable 'act' can be reduced.
EionRobb added a commit that referenced this issue Aug 30, 2019
@EionRobb

This comment has been minimized.

Copy link
Owner

commented Aug 30, 2019

Thanks :)

@EionRobb EionRobb closed this Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.