New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #11

Merged
merged 3 commits into from Feb 16, 2016

Conversation

Projects
None yet
2 participants
@chuganzy
Contributor

chuganzy commented Jan 5, 2016

As titled. Fixes #8 and #10.

@reallyseth reallyseth referenced this pull request Jan 6, 2016

Closed

Carthage Support #12

@Ekhoo

This comment has been minimized.

Show comment
Hide comment
@Ekhoo

Ekhoo Feb 16, 2016

Owner

Hello, thank you for your PR, I will test it and if it's ok I will merge it :)

Owner

Ekhoo commented Feb 16, 2016

Hello, thank you for your PR, I will test it and if it's ok I will merge it :)

@Ekhoo

This comment has been minimized.

Show comment
Hide comment
@Ekhoo

Ekhoo Feb 16, 2016

Owner

Hello, there are some conflitcts with your PR. If you want to fix it you can, otherwise I will merge #12. Tell me what you prefer :)

Owner

Ekhoo commented Feb 16, 2016

Hello, there are some conflitcts with your PR. If you want to fix it you can, otherwise I will merge #12. Tell me what you prefer :)

Takeru Chuganji
Merge branch 'Ekhoo/master' into carthage_support
# Conflicts:
#	Device.xcodeproj/project.pbxproj
@chuganzy

This comment has been minimized.

Show comment
Hide comment
@chuganzy

chuganzy Feb 16, 2016

Contributor

Done!

Contributor

chuganzy commented Feb 16, 2016

Done!

@Ekhoo

This comment has been minimized.

Show comment
Hide comment
@Ekhoo

Ekhoo Feb 16, 2016

Owner

Oh great :) Thank you very much :)

Owner

Ekhoo commented Feb 16, 2016

Oh great :) Thank you very much :)

@Ekhoo

This comment has been minimized.

Show comment
Hide comment
@Ekhoo

Ekhoo Feb 16, 2016

Owner

I merge ! And I will build a new release today

Owner

Ekhoo commented Feb 16, 2016

I merge ! And I will build a new release today

Ekhoo added a commit that referenced this pull request Feb 16, 2016

@Ekhoo Ekhoo merged commit f7218fc into Ekhoo:master Feb 16, 2016

@Ekhoo Ekhoo referenced this pull request Feb 16, 2016

Closed

Carthage build failed #10

@chuganzy

This comment has been minimized.

Show comment
Hide comment
@chuganzy

chuganzy Feb 16, 2016

Contributor

👍

Contributor

chuganzy commented Feb 16, 2016

👍

@Ekhoo

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment