Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated lidar mesh #165

Merged

Conversation

IDavGal
Copy link
Contributor

@IDavGal IDavGal commented Oct 4, 2023

🦟 Bug fix

Fixes #160

Summary

Reduced lidar mesh complexity, for correctly casting shadows and reduce issues, as mentioned in the corresponding issue.

The new mesh in webots and gazebo:
image_2023-10-03_12-03-17

gazebo_shadow

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: IDavGal <ignacio.davila@ekumenlabs.com>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome! Thanks for the contribution, looks great now!

@francocipollone francocipollone merged commit 798cdcf into Ekumen-OS:humble Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants