Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code does not build at all #335

Closed
cm0x4D opened this issue Dec 8, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@cm0x4D
Copy link
Member

commented Dec 8, 2015

Eln.java:533: error: cannot find symbol
stdHalfLife = config.get("battery", "batteryHalfLife", 2, "How many days it takes for a battery to decay half way").getDouble(2) * Utils.minecraftDay;
^
symbol: variable stdHalfLife
location: class Eln

Seems the error was introduced with commit e6f5935.

@cm0x4D cm0x4D closed this in 9aa84de Dec 8, 2015

@cm0x4D

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2015

@Dolu1990, @lambdaShade, @metc, @Baughn
As we have to merge more and more pull requests, it would be useful to add a continuous integration system in order to check if the pull requests actually compile before merging them. What do you think?

@metc

This comment has been minimized.

Copy link
Member

commented Dec 8, 2015

Yes, we should at least check if the code compiles without error.
Using Travis or any other CI system, if the sanity check fails, a warning is displayed before merging the PR. This would help a lot.

@Baughn

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2015

Geh. Well, definitely a good idea. Didn't @metc setup Travis for the website just yesterday?

@Baughn

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2015

Seems simple enough. I'll just file a bug against myself, and—

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.