Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Transifex for translations #380

Closed
cm0x4D opened this issue Jan 7, 2016 · 11 comments
Closed

Switch to Transifex for translations #380

cm0x4D opened this issue Jan 7, 2016 · 11 comments
Assignees
Milestone

Comments

@cm0x4D
Copy link
Member

@cm0x4D cm0x4D commented Jan 7, 2016

@cm0x4D cm0x4D self-assigned this Jan 7, 2016
@cm0x4D cm0x4D added this to the Release r51 milestone Jan 7, 2016
@cm0x4D
Copy link
Member Author

@cm0x4D cm0x4D commented Jan 7, 2016

@Electrical-Age/devs What do you think?
I gave it a try and it works really well.

@metc
Copy link
Member

@metc metc commented Jan 8, 2016

@metc
Copy link
Member

@metc metc commented Jan 8, 2016

Here are the most used languages by the mod users:
image

@metc
Copy link
Member

@metc metc commented Jan 8, 2016

@Baughn you are English native speaker. Could you have a look at the English file language on the Transifex page please ? It would be great if you could have a look at the current English translations before adding more languages.
Have a look and if your are interested and if you have some time ;)

@cm0x4D
Copy link
Member Author

@cm0x4D cm0x4D commented Jan 8, 2016

@Electrical-Age/devs If someone wants to improve the english texts, please do it in the language file and not in code as the keys are already used for translation...

@metc
Copy link
Member

@metc metc commented Jan 10, 2016

I added a configuration file for Transifex, see 2250a04. I also added a script to push lang files to Transifex automatically after a successful Travis build.
@cm0x4D can you also test this locally and then I will enable it on Travis ?

@Baughn
Copy link
Contributor

@Baughn Baughn commented Jan 10, 2016

@metc If I start doing a typo pass, I'll probably end up bulk-renaming things in the source code again. There are a lot of typos there.

But I'l take a look, sure.

@cm0x4D
Copy link
Member Author

@cm0x4D cm0x4D commented Jan 10, 2016

@Baughn You can fix them in the en_US.lang file too. Otherwise new keys for the language files are created and we have to start over translating all other languages too.

@metc
Copy link
Member

@metc metc commented Jan 10, 2016

@Baughn you are now part of the ELN organisation on Transifex and of course you manage the Norwegian translations ;)

@cm0x4D
Copy link
Member Author

@cm0x4D cm0x4D commented Jan 10, 2016

@metc

  • just ensure that the updateMasterLanguageFile gradle task is run before to update the language file.
  • there is still a problem with the script: /home/travis/build.sh: line 45: ./script/transifex.sh: Permission denied

On every travis build we update the en_US.lang file on Transifex? Did I understood that right?
Ok for me then.

There is no support yet to automatically download and install translations from Transifex in Eln?
Would it not make more sense to create a gradle task for uploading the resource and downloading the translations?
So we would not need to install the transifex client: http://docs.transifex.com/api/resources/

@metc metc mentioned this issue Jan 11, 2016
@metc metc added the language label Jan 11, 2016
@cm0x4D
Copy link
Member Author

@cm0x4D cm0x4D commented Apr 11, 2016

Translated into 7 languages, 19 on the way <3
A big thank to all contributors!!

@cm0x4D cm0x4D closed this Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.