Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Observer Tools #260

Merged
merged 13 commits into from Jan 29, 2020
Merged

Add Observer Tools #260

merged 13 commits into from Jan 29, 2020

Conversation

@applenick
Copy link
Contributor

applenick commented Jan 25, 2020

Observer Tools

Resolves #220
Inspiration was taken mostly from @Pablete1234's comment on that issue. Thanks!

Features:

This implementation of an observer tool set adds a new GUI menu for observers to interact with. While simple in functionality, this will most certainly prove useful for users who want more control over the features described below. I've designed this feature set with future improvements/additions in mind, so with minimal tweaking more tools/features can be added to the GUI if desired.

overview

Fly Speed

Adjust the flight speed between 4 set values. I performed a bit of testing between several values to see what made a difference to the user, and I believe the values chosen are good.

Also I used the names Regular, Fast, Faster, and Hyperspeed as user friendly names to define the speeds. As I felt that using numbers would be more confusing. If anyone has better suggestions for names or speed values, I'm open to adjusting them.

fly-speed

Night Vision

Allows the player to toggle night vision on/off. Potions are removed when joining matches, so this will not interfere in anyway. This also does not persist between matches, so users will be able to decide on a per match basis if they want night vision on or not.

night-vision

Toggle Visibility

Simply toggles the Observer visibility setting.

obs-vis

Gamemode

This was one of the more tricky additions, as it toggles the observer between Creative and Spectator mode. Since the regular hotbar is not accessible while in Spectator, once the user clicks the tool, a message will be sent in the chat. Stating in order to access this menu they must use the /tools command.

Also I made sure to include the /! command as suggested by @Pablete1234.

gamemode

Future Improvements

As stated earlier, I feel this menu has the potential to house more useful tools. Hopefully with community feedback, we can gather new ideas and implement them when needed.

There was one feature I feel could be implemented, though I chose not to for simplicity sake before receiving feedback. It would be allowing players the option to add one of the setting "tools" to their hotbar to easily activate the setting. For example, were the night vision tool added to the hotbar the user when clicking the item would be able to toggle night vision on/off without opening the inventory menu.

Final Note

Just wanted to state, I did not add any config options to this. As I feel nothing here would disrupt gameplay in a way server owners would want to disable it. However if that is requested it can be added.

Signed-off-by: applenick applenick@users.noreply.github.com

Signed-off-by: applenick <applenick@users.noreply.github.com>
@applenick applenick requested a review from Electroid as a code owner Jan 25, 2020
Signed-off-by: applenick <applenick@users.noreply.github.com>
Signed-off-by: applenick <applenick@users.noreply.github.com>
Signed-off-by: applenick <applenick@users.noreply.github.com>
applenick added 2 commits Jan 26, 2020
Signed-off-by: applenick <applenick@users.noreply.github.com>
Signed-off-by: applenick <applenick@users.noreply.github.com>
applenick added 2 commits Jan 26, 2020
Signed-off-by: applenick <applenick@users.noreply.github.com>
Signed-off-by: applenick <applenick@users.noreply.github.com>
@applenick applenick requested a review from Pablete1234 Jan 26, 2020
applenick added 3 commits Jan 27, 2020
Signed-off-by: applenick <applenick@users.noreply.github.com>
Signed-off-by: applenick <applenick@users.noreply.github.com>
Signed-off-by: applenick <applenick@users.noreply.github.com>
@Pablete1234 Pablete1234 merged commit a414a5f into Electroid:master Jan 29, 2020
2 checks passed
2 checks passed
build
Details
DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.