forked from spesmilo/electrum
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Do not broadcast transaction for a payment request (#868)
* Do not broadcast transaction for a payment request A transaction from a BIP70 invoice should not be broadcasted by the wallet. If a valid PaymentACK is received it is up to the merchant to broadcast the transaction. This also fixes a nasty race condition where a transaction was broadcasted before the merchant had ACK'd it which would likley cause the user to loose money. Also updated the memo field from "Electrum" to "Electron Cash". Fixes #812 * Explicitly check for HTTP 200 OK for PaymentACK A payment processor using BIP70 shall respond with HTTP 200 OK status response. * Propagate error message from paymentrequest * Change send_ack to send_payment in paymentrequest The function is sending a Payment message and receiving a PaymentACK message and thus it was incorrectly named. * Dont save and mark payment req as paid on failure
- Loading branch information
1 parent
9a65c0a
commit abf57d5
Showing
2 changed files
with
14 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters