Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable (optional) encryption for watch-only and hardware wallet files #750
I was under the impression this also allowed for PW encryption of "watching only" wallets. if it's a hw wallet only change -- which actually it looks like it is -- I may not want to touch it as I lack hardware wallets to test this with.…
On Mon, Jun 25, 2018 at 9:48 PM, marceloneil ***@***.***> wrote: I'm confused, this is a hardware wallet change. Does IOS support OTG for hardware wallets? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#750 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQRg1_ghpqvYopwWXjS2VTJtDhIXxaiks5uATCBgaJpZM4U1AVa> .
I want to clarify the intention of this issue since I filed it.
When I create a wallet based on a HW wallet, I cannot encrypt the file with a password. That means if I put the wallet file somewhere, anyone can open it and see the transaction history, xpub, whatever. That's not good. This is what should be fixed. If I remember correctly, watch-only wallets have the same missing feature? Not sure about that part.
In any case, encrypting the wallet file so that it can be placed on cloud storage and things like that without worrying too much is the main point.
I'm also updating this so I can test a bounty system someone invited me to try out!