Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable (optional) encryption for watch-only and hardware wallet files #750

Open
emergent-reasons opened this issue Jun 24, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@emergent-reasons
Copy link

commented Jun 24, 2018

/u/Merculeses suggested I file this for now.

It is a resolved issue in elecrum.

This is the resolving PR.

My use case is to have a convenient layer of privacy when backing up to a cloud service.

@marceloneil

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2018

That's a valid use case, I'll get to this when porting some of the trezor changes and trezor one code, so hopefully by the next release

@marceloneil marceloneil added this to the 3.3.1 milestone Jun 25, 2018

@cculianu

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2018

I can also work on this once I get iOS out -- since iOS users have been asking for this feature as well.

After July 1st I'll be available.. if Marcel doesn't do it before then.

@marceloneil

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2018

I'm confused, this is a hardware wallet change. Does iOS support OTG for hardware wallets?

@cculianu

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2018

@marceloneil

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2018

That would be #609

@cculianu

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2018

Ah gotcha. I definitely can do the watching-only part of it. The hardware wallet I'm afraid to touch if I can't test it...

@cculianu cculianu modified the milestones: 3.3.1, 3.3.2 Jul 15, 2018

@cculianu cculianu modified the milestones: 3.3.2, 3.3.3 Nov 10, 2018

@cculianu cculianu removed this from the 3.3.3 milestone Feb 21, 2019

@emergent-reasons

This comment has been minimized.

Copy link
Author

commented Mar 17, 2019

I want to clarify the intention of this issue since I filed it.

When I create a wallet based on a HW wallet, I cannot encrypt the file with a password. That means if I put the wallet file somewhere, anyone can open it and see the transaction history, xpub, whatever. That's not good. This is what should be fixed. If I remember correctly, watch-only wallets have the same missing feature? Not sure about that part.

In any case, encrypting the wallet file so that it can be placed on cloud storage and things like that without worrying too much is the main point.

I'm also updating this so I can test a bounty system someone invited me to try out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.