New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet electronize build should not npm install #51

Closed
yoDon opened this Issue Nov 12, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@yoDon
Contributor

yoDon commented Nov 12, 2017

Building and Starting are currently much slower than necessary because every build and every start does a bunch of npm install like tasks that take much longer than the actual build.

The install steps should be handled by a restore or install command, so we don't need to wait for them to complete each time we build/start (or alternatively could we have rebuild/restart commands that are lighter-weight than the full build/start commands, if you want to keep the installs in place?)

@robertmuehsig

This comment has been minimized.

Show comment
Hide comment
@robertmuehsig

robertmuehsig Nov 12, 2017

Collaborator

At least the start is "faster", because if start detects the node_modules folder it doesn't do a npm install, maybe build should to the same. Good feedback - will consider it for the next drop 👍

Collaborator

robertmuehsig commented Nov 12, 2017

At least the start is "faster", because if start detects the node_modules folder it doesn't do a npm install, maybe build should to the same. Good feedback - will consider it for the next drop 👍

@robertmuehsig robertmuehsig added this to the 0.0.8 milestone Nov 15, 2017

robertmuehsig added a commit that referenced this issue Nov 15, 2017

@robertmuehsig

This comment has been minimized.

Show comment
Hide comment
@robertmuehsig

robertmuehsig Nov 15, 2017

Collaborator

Works like the start enhancement - if we detect the node_modules folder, we skip npm install.

Maybe we need a --force command later on to reinstall npm packages if needed.

Collaborator

robertmuehsig commented Nov 15, 2017

Works like the start enhancement - if we detect the node_modules folder, we skip npm install.

Maybe we need a --force command later on to reinstall npm packages if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment