From a5543bfe606af66a54fd91b3cffa500618f6bed4 Mon Sep 17 00:00:00 2001 From: Konstantin Gross Date: Wed, 20 May 2020 18:58:31 +0200 Subject: [PATCH 1/3] Typo in summary --- ElectronNET.API/NativeTheme.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ElectronNET.API/NativeTheme.cs b/ElectronNET.API/NativeTheme.cs index 81770e9c..037a97a6 100644 --- a/ElectronNET.API/NativeTheme.cs +++ b/ElectronNET.API/NativeTheme.cs @@ -89,7 +89,7 @@ internal static NativeTheme Instance /// /// Your application should then always use to determine what CSS to apply. /// - /// The new ThemeSource. + /// The new ThemeSource. public void SetThemeSource(ThemeSourceMode themeSourceMode) { var themeSource = themeSourceMode.GetDescription(); From 8c250ae83e8794c10f75fbf800b3b3681e50e0c6 Mon Sep 17 00:00:00 2001 From: Konstantin Gross Date: Wed, 20 May 2020 18:59:38 +0200 Subject: [PATCH 2/3] Add ConfigurationProfile paramter to electronize start command --- ElectronNET.CLI/Commands/StartElectronCommand.cs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ElectronNET.CLI/Commands/StartElectronCommand.cs b/ElectronNET.CLI/Commands/StartElectronCommand.cs index b72d7bda..64c0f8ba 100644 --- a/ElectronNET.CLI/Commands/StartElectronCommand.cs +++ b/ElectronNET.CLI/Commands/StartElectronCommand.cs @@ -27,6 +27,7 @@ public StartElectronCommand(string[] args) private string _manifest = "manifest"; private string _clearCache = "clear-cache"; private string _paramPublishReadyToRun = "PublishReadyToRun"; + private string _paramDotNetConfig = "dotnet-configuration"; public Task ExecuteAsync() { @@ -73,9 +74,15 @@ public Task ExecuteAsync() publishReadyToRun += "true"; } + string configuration = "Release"; + if (parser.Arguments.ContainsKey(_paramDotNetConfig)) + { + configuration = parser.Arguments[_paramDotNetConfig][0]; + } + if (parser != null && !parser.Arguments.ContainsKey("watch")) { - resultCode = ProcessHelper.CmdExecute($"dotnet publish -r {platformInfo.NetCorePublishRid} --output \"{tempBinPath}\" {publishReadyToRun} --no-self-contained", aspCoreProjectPath); + resultCode = ProcessHelper.CmdExecute($"dotnet publish -r {platformInfo.NetCorePublishRid} -c {configuration} --output \"{tempBinPath}\" {publishReadyToRun} --no-self-contained", aspCoreProjectPath); } if (resultCode != 0) From bb3d073fae1d4e2f71100dfa7cf15cdd679b3412 Mon Sep 17 00:00:00 2001 From: Konstantin Gross Date: Wed, 20 May 2020 19:02:15 +0200 Subject: [PATCH 3/3] Custom user path removed and replaced by the correct directory with VS macro --- ElectronNET.CLI/Properties/launchSettings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ElectronNET.CLI/Properties/launchSettings.json b/ElectronNET.CLI/Properties/launchSettings.json index 819d7fec..934f42bd 100644 --- a/ElectronNET.CLI/Properties/launchSettings.json +++ b/ElectronNET.CLI/Properties/launchSettings.json @@ -2,7 +2,7 @@ "profiles": { "ElectronNET.CLI": { "commandName": "Project", - "commandLineArgs": "start /project-path \"C:\\Users\\Rizvi\\source\\repos\\Electron.NET\\ElectronNET.WebApp\" /watch" + "commandLineArgs": "start /project-path \"$(SolutionDir)\\ElectronNET.WebApp\" /watch" } } } \ No newline at end of file