New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use a-z, 0-9 and _ for file names #1615

Open
markus2330 opened this Issue Oct 6, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@markus2330
Contributor

markus2330 commented Oct 6, 2017

We have inconsistent use of characters in file names, which always requires one to think which kind of separator is used in specific cases.

~e> find . -name '*-*' | wc -l
386
~e> find . -name '*_*' | wc -l
491
~e> find . -name '* *' | wc -l
0

As short time goal we should not introduce new variants (such as spaces, see #1613), as 1.0 goal I propose to unify it to a single variant.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Mar 30, 2018

Contributor

Latest results:

~e> find . -name '*-*' | grep -v "^./.git/" | wc -l                                                                                                                                                                                          
416
~e> find . -name '*_*' | grep -v "^./.git/" | wc -l                                                                                                                                                                                          
538

Ideally we would have a script that automatically renames everything based on conventions, in the same way we have it with clang-format. I'd prefer not to have to discuss about such conventions 😉

At the moment find . | grep -v '^[-_/.a-zA-Z0-9]*$' seems to be clean, we could add a check for this, see #160.

Contributor

markus2330 commented Mar 30, 2018

Latest results:

~e> find . -name '*-*' | grep -v "^./.git/" | wc -l                                                                                                                                                                                          
416
~e> find . -name '*_*' | grep -v "^./.git/" | wc -l                                                                                                                                                                                          
538

Ideally we would have a script that automatically renames everything based on conventions, in the same way we have it with clang-format. I'd prefer not to have to discuss about such conventions 😉

At the moment find . | grep -v '^[-_/.a-zA-Z0-9]*$' seems to be clean, we could add a check for this, see #160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment