New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Login broken #1679

Closed
markus2330 opened this Issue Oct 31, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@markus2330
Contributor

markus2330 commented Oct 31, 2017

@Namoshek wrote:

The login does work, the token is stored and the user is authenticated (which is also visible after refreshing the page). But for some reason, both the .then(function(response) { ... }) and the .catch(function(response) { ... }) functions are called in the AuthLoginController.js. The login method on the authentication service is called as described in their API though. And there have been no changes to the satellizer project since mid 2016, which was before we had a working build. So I'm pretty much clueless.

What about disabling login? Might be better than to have a non-working login?

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Jan 4, 2018

Contributor

I am considering to mention the snippet sharing (and the more general topic that (mis)configurations should be treated as free software and should be shared) but it would not be wise to recommend something where the login does not work.

Any plans to reactivate the login? Or allow anonymous posting of snippets? Or use the new version from @vanessaNWK ?

Contributor

markus2330 commented Jan 4, 2018

I am considering to mention the snippet sharing (and the more general topic that (mis)configurations should be treated as free software and should be shared) but it would not be wise to recommend something where the login does not work.

Any plans to reactivate the login? Or allow anonymous posting of snippets? Or use the new version from @vanessaNWK ?

Namoshek pushed a commit to Namoshek/libelektra that referenced this issue Jan 5, 2018

Namoshek
rest-frontend: update dependency version for angular-ui-notification …
…to newest

this change will hopefully fix the login issue discussed in ElektraInitiative#1679 and ElektraInitiative#1678
@Namoshek

This comment has been minimized.

Show comment
Hide comment
@Namoshek

Namoshek Jan 5, 2018

Contributor

It looks like one of the dependencies is causing the (display-only) issue with the login. The angular-ui-notification package was changed due to the same requirements of the angular core package as have been done in #1678. What I don't understand is why still the old version of the package is used in the build, because we used "angular-ui-notification": "^0.2.0" in the dependency tree, what means it should use all newer versions up to, but excluding 1.0.0. And the newest is 0.3.6 (for quite some time already).

As my development VM is not working anymore after upgrading to Windows 10 some time ago (I guess it has to do with me enabling Hyper-V for Docker...), it is not very easy for me to test things locally. I created a PR with a minor change (#1772) that potentially fixes the issue. I hope it does not introduce other compatibility issues though.

Contributor

Namoshek commented Jan 5, 2018

It looks like one of the dependencies is causing the (display-only) issue with the login. The angular-ui-notification package was changed due to the same requirements of the angular core package as have been done in #1678. What I don't understand is why still the old version of the package is used in the build, because we used "angular-ui-notification": "^0.2.0" in the dependency tree, what means it should use all newer versions up to, but excluding 1.0.0. And the newest is 0.3.6 (for quite some time already).

As my development VM is not working anymore after upgrading to Windows 10 some time ago (I guess it has to do with me enabling Hyper-V for Docker...), it is not very easy for me to test things locally. I created a PR with a minor change (#1772) that potentially fixes the issue. I hope it does not introduce other compatibility issues though.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Jan 5, 2018

Contributor

Thank you for fixing this problem!

It is perfectly reasonable to create a pull request and let the build servers check if it works.

Contributor

markus2330 commented Jan 5, 2018

Thank you for fixing this problem!

It is perfectly reasonable to create a pull request and let the build servers check if it works.

@markus2330 markus2330 closed this Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment