Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
dini: Plugin Breaks Test Suite #1713
Unfortunately the latest merge commit to master breaks
It would be great if we require that everyone opens a pull request before she or he merges non-trivial changes. This way we can check if new code breaks anything. Merging non-working code to
referenced this issue
Dec 3, 2017
Thank you for reporting the issue!
Sorry, my mistake. Unfortunately, we do not have a workflow to build a Debian package with a new plugin without merging to master first. Thus I merged it without creating a PR. I opened a separate issue for the workflow problem in #1714. Nevertheless, you are right: not breaking the master is more important than being able to build Debian packages sooner. I thought that a new experimental plugin in master is acceptable (even if it does not work) but it seems like my assumption was wrong.
This build job should be changed to use dini instead. But more work is needed until this works.
I saw this already but I have not found the problem yet. (And I get different ASAN errors locally, not caused by this PR, so I cannot reproduce.) Might be fixed with 518440b.
@sanssecours What about dropping support for Ubuntu Trusty (14.04)? (Or at least the ASAN build for it.) It is even older than Debian Jessie (April 26th, 2015).
I wonder in which ways travis modified Trusty. (Or is it even using Ubuntu Trusty?) When I bootstrapped trusty I got cmake v2.8, not supported by Elektra anymore. Thus I could not reproduce the ASAN problem.
I do not like the idea. I just fixed two memory leaks reported by the Travis ASAN build. However, I agree that Ubuntu Trusty is (horribly) outdated. As far as I can tell Travis should add support for the less outdated Ubuntu Xenial on December 11th
The Travis documentation lists some of the modifications. The documentation is quite vague though:
. At least I do not really know what version of CMake is considered “modern”.
Thank you for the quick reply!
If they exchange core components they should not call it Ubuntu Trusty.
So lets wait for 3 days and see which ASAN errors we get with Ubuntu Xenial. (Hopefully they provide a real Ubuntu Xenial and not a modified one.)
Seems like elektra-ini-mergerequest is now fixed. For ASAN multiple problems exist:
Were they all introduced with the dini plugin?
fail both on Travis and on Jenkins. Since the Travis ASAN build worked before commit 2bac405, I would assume the failures were introduced by
show problems in