New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multifile plugin depends on fts.h not available everywhere #1757

Closed
haraldg opened this Issue Dec 26, 2017 · 2 comments

Comments

4 participants
@haraldg

haraldg commented Dec 26, 2017

Steps to Reproduce the Problem

try compiling libelektra with musl libc - like crosscompiling for OpenWRT:
The file fts.h is not found

It seems some people have a grudge against the fts* interface:
https://wiki.musl-libc.org/faq.html

System Information

  • Elektra Version: 0.8.21
  • Versions of other relevant software?

log output

[ 42%] Building C object src/plugins/multifile/CMakeFiles/elektra-multifile-objects.dir/multifile.c.o
/home/lambda/olinuxino/openwrt/build_dir/target-arm_arm926ej-s_musl-1.1.15_eabi/elektra-0.8.21/src/plugins/multifile/multifile.c:15:17: fatal error: fts.h: No such file or directory
compilation terminated.
src/plugins/multifile/CMakeFiles/elektra-multifile-objects.dir/build.make:62: recipe for target 'src/plugins/multifile/CMakeFiles/elektra-multifile-objects.dir/multifile.c.o' failed
make[5]: *** [src/plugins/multifile/CMakeFiles/elektra-multifile-objects.dir/multifile.c.o] Error 1

@markus2330 markus2330 added this to the 0.8.22 milestone Dec 26, 2017

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Dec 26, 2017

Contributor

Thank you for reporting!

As temporary fix you can add -multifile to PLUGINS in cmake (to exclude the plugin which does not compile).

For the next release, we will add a check for this header file and remove the plugin multifile automatically on absence of the header file. Or do you think that the functionality of the multifile plugin is needed for musl targets?

Contributor

markus2330 commented Dec 26, 2017

Thank you for reporting!

As temporary fix you can add -multifile to PLUGINS in cmake (to exclude the plugin which does not compile).

For the next release, we will add a check for this header file and remove the plugin multifile automatically on absence of the header file. Or do you think that the functionality of the multifile plugin is needed for musl targets?

@haraldg

This comment has been minimized.

Show comment
Hide comment
@haraldg

haraldg Dec 27, 2017

I don't know of any usecase for this plugin ATM - so probably not. OTOH almost any software can run on musl targets, so if applications start using elektra and start using this plugin it might become an issue in the future. I wouldn't bother about this for now, but maybe it makes sense to look into why peope dislike this API before deciding how to proceed.

haraldg commented Dec 27, 2017

I don't know of any usecase for this plugin ATM - so probably not. OTOH almost any software can run on musl targets, so if applications start using elektra and start using this plugin it might become an issue in the future. I wouldn't bother about this for now, but maybe it makes sense to look into why peope dislike this API before deciding how to proceed.

@sanssecours sanssecours self-assigned this Feb 16, 2018

sanssecours added a commit to sanssecours/elektra that referenced this issue Feb 16, 2018

sanssecours added a commit to sanssecours/elektra that referenced this issue Feb 17, 2018

sanssecours added a commit to sanssecours/elektra that referenced this issue Feb 17, 2018

sanssecours added a commit to sanssecours/elektra that referenced this issue Feb 17, 2018

sanssecours added a commit to sanssecours/elektra that referenced this issue Feb 17, 2018

@sanssecours sanssecours referenced this issue Feb 17, 2018

Merged

Various Small Fixes #1818

4 of 4 tasks complete

sanssecours added a commit to sanssecours/elektra that referenced this issue Mar 2, 2018

@markus2330 markus2330 added this to to fix in lcdproc Mar 31, 2018

@markus2330 markus2330 moved this from to fix to implemented in lcdproc Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment