New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elektra-web 1.2 tasks #1759

Closed
omnidan opened this Issue Dec 27, 2017 · 12 comments

Comments

Projects
None yet
2 participants
@omnidan
Contributor

omnidan commented Dec 27, 2017

  • search works like a filter of already expanded/loaded items right now, it doesn't search through the whole configuration tree - this is performance expensive as we'd have to kdb get on every key... might make more sense once elektrad is replaced with an actual api -> elbywan/bosket#20
  • setting validation regex and message when editing metadata
  • setting negative numbers does not work. in the kdb command, this translates to kdb set key "-6", but even with the " kdb still picks 6 up as an option, not the value.
  • implement read-only/disabled keys (+ configuration via metadata)
  • always display description (where?), display example as placeholder for text fields
  • debounce requests when editing metadata and data (e.g. description field, etc), reduces load on the server/API
  • move api to /api/ to fix routing issues
  • implement css fallback for firefox esr
  • fix anchors for icon buttons
  • show "loading..." instead of "no results found" when no data is available yet

@markus2330 reported:

  • fix and test Firefox+FirefoxESR
  • it is not possible to mark text (in value)
  • some way to copy&paste the full key name/value missing?
  • custom field to create ranges (instead of putting them in as a string)
  • please avoid special syntax to specify enums (please add some interface where new valid enum entries can be added). Please also use new syntax (check/enum/#). And make sure to change check/type accordingly when enum is set.
  • not possible to add further arbitrary metadata
  • support for some more metadata such as check/range (to specify integer ranges)
  • values might be invalid after the type has been changed (warning? especially irritating when changing to checkbox because then the actual value is not visible anymore)
  • no hints when hoovering the symbols
  • how to reload config from disk? And better feedback if everything was already written out?

Fosdem:

  • The webUI seems to have several problems with keys that were removed earlier (outside the WebUI). Refreshing does not work as expected.
  • Firefox rendering is quite broken.
  • Subkeys (parentkeys) containing values are not rendered properly. (e.g. /parent = 1, and /parent/key = 2, the 1 is not displayed correctly).

@omnidan omnidan self-assigned this Dec 27, 2017

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Dec 27, 2017

Contributor

Thank you for reporting the issues! I'll add further issues here if I find them and if this is okay for you.

elektrad is replaced with an actual api

As long as you need to requests for every key individually it might be quite expensive. You need some way to export a whole tree with a single API call. Didn't we discuss such export capabilities?

setting negative numbers does not work. in the kdb command, this translates to kdb set key "-6", but even with the " kdb still picks 6 up as an option, not the value.

This should be a trivial fix: Add -- as parameter to indicate that no flags follow. And you should use single quotes ' to avoid escaping problems of !~$ and so on.

always display description (where?)

As hover text sounds reasonable. Maybe also add a ? icon to indicate that a hover text exists?

Contributor

markus2330 commented Dec 27, 2017

Thank you for reporting the issues! I'll add further issues here if I find them and if this is okay for you.

elektrad is replaced with an actual api

As long as you need to requests for every key individually it might be quite expensive. You need some way to export a whole tree with a single API call. Didn't we discuss such export capabilities?

setting negative numbers does not work. in the kdb command, this translates to kdb set key "-6", but even with the " kdb still picks 6 up as an option, not the value.

This should be a trivial fix: Add -- as parameter to indicate that no flags follow. And you should use single quotes ' to avoid escaping problems of !~$ and so on.

always display description (where?)

As hover text sounds reasonable. Maybe also add a ? icon to indicate that a hover text exists?

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Jan 13, 2018

Contributor

As discussed, please test with Firefox+FirefoxESR. (I added the point above)

Contributor

markus2330 commented Jan 13, 2018

As discussed, please test with Firefox+FirefoxESR. (I added the point above)

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Jan 27, 2018

Contributor

I quickly tested the webUI a bit with chromium and reported some problems I found (also see above):

  • fix and test Firefox+FirefoxESR
  • it is not possible to mark text (in value)
  • some way to copy&paste the full key name/value missing?
  • please avoid special syntax to specify enums (please add some interface where new valid enum entries can be added). Please also use new syntax (check/enum/#). And make sure to change check/type accordingly when enum is set.
  • not possible to add further arbitrary metadata
  • support for some more metadata such as check/range (to specify integer ranges)
  • values might be invalid after the type has been changed (warning? especially irritating when changing to checkbox because then the actual value is not visible anymore)
  • no hints when hoovering the symbols
  • how to reload config from disk? And better feedback if everything was already written out?

It would be great if it works with Firefox so that I can also do some testing there.

Contributor

markus2330 commented Jan 27, 2018

I quickly tested the webUI a bit with chromium and reported some problems I found (also see above):

  • fix and test Firefox+FirefoxESR
  • it is not possible to mark text (in value)
  • some way to copy&paste the full key name/value missing?
  • please avoid special syntax to specify enums (please add some interface where new valid enum entries can be added). Please also use new syntax (check/enum/#). And make sure to change check/type accordingly when enum is set.
  • not possible to add further arbitrary metadata
  • support for some more metadata such as check/range (to specify integer ranges)
  • values might be invalid after the type has been changed (warning? especially irritating when changing to checkbox because then the actual value is not visible anymore)
  • no hints when hoovering the symbols
  • how to reload config from disk? And better feedback if everything was already written out?

It would be great if it works with Firefox so that I can also do some testing there.

markus2330 added a commit that referenced this issue Jan 27, 2018

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Jan 31, 2018

Contributor

We tried to do preparations for the FOSDEM presentation.

  • The webUI seems to have several problems with keys that were removed earlier (outside the WebUI). Refreshing does not work as expected.
  • Firefox rendering is quite broken.
  • Subkeys (parentkeys) containing values are not rendered properly. (e.g. /parent = 1, and /parent/key = 2, the 1 is not displayed correctly).

Can you fix this?

Contributor

markus2330 commented Jan 31, 2018

We tried to do preparations for the FOSDEM presentation.

  • The webUI seems to have several problems with keys that were removed earlier (outside the WebUI). Refreshing does not work as expected.
  • Firefox rendering is quite broken.
  • Subkeys (parentkeys) containing values are not rendered properly. (e.g. /parent = 1, and /parent/key = 2, the 1 is not displayed correctly).

Can you fix this?

@omnidan

This comment has been minimized.

Show comment
Hide comment
@omnidan

omnidan Feb 13, 2018

Contributor

Firefox 53+ works fine. Unfortunately, css masks are only supported from firefox 53 (and ESR is 52), which is why ESR only renders black bars. Furthermore, ESR renders quite slow compared to the newer firefox versions. I will look into ESR support again later. However, it is not a priority right now.

Contributor

omnidan commented Feb 13, 2018

Firefox 53+ works fine. Unfortunately, css masks are only supported from firefox 53 (and ESR is 52), which is why ESR only renders black bars. Furthermore, ESR renders quite slow compared to the newer firefox versions. I will look into ESR support again later. However, it is not a priority right now.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Feb 13, 2018

Contributor

Thank you for looking into it. For me Firefox ESR is the standard browser thus I always check with it first. Would be great to get it fixed.

I thought such problems are only of the past. I am looking forward to read about the details how the rendering works and how this can cause problems in any browser.

Contributor

markus2330 commented Feb 13, 2018

Thank you for looking into it. For me Firefox ESR is the standard browser thus I always check with it first. Would be great to get it fixed.

I thought such problems are only of the past. I am looking forward to read about the details how the rendering works and how this can cause problems in any browser.

@omnidan

This comment has been minimized.

Show comment
Hide comment
@omnidan

omnidan Mar 15, 2018

Contributor

@markus2330 I added a workaround for all browsers that do not support css mask, which fixes the issue on Firefox ESR. I also finished almost all the tasks, so elektra-web is ready for the usability test now. I will create a MR with all the changes tomorrow.

Contributor

omnidan commented Mar 15, 2018

@markus2330 I added a workaround for all browsers that do not support css mask, which fixes the issue on Firefox ESR. I also finished almost all the tasks, so elektra-web is ready for the usability test now. I will create a MR with all the changes tomorrow.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Mar 15, 2018

Contributor

Great! I'll look at it asap, so that you can start the usability test soon.

Contributor

markus2330 commented Mar 15, 2018

Great! I'll look at it asap, so that you can start the usability test soon.

@omnidan

This comment has been minimized.

Show comment
Hide comment
@omnidan
Contributor

omnidan commented Mar 15, 2018

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Mar 15, 2018

Contributor

Please create a PR, it is easier for discussions.

Contributor

markus2330 commented Mar 15, 2018

Please create a PR, it is easier for discussions.

@omnidan

This comment has been minimized.

Show comment
Hide comment
@omnidan
Contributor

omnidan commented Mar 15, 2018

@omnidan omnidan referenced this issue Mar 15, 2018

Merged

Elektra Web 1.2 #1839

5 of 5 tasks complete

@markus2330 markus2330 referenced this issue Mar 18, 2018

Closed

Elektra-web 1.2 tasks #1845

32 of 34 tasks complete
@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Mar 18, 2018

Contributor

moved tasks to #1845

Contributor

markus2330 commented Mar 18, 2018

moved tasks to #1845

@markus2330 markus2330 closed this Mar 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment