New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make removal of test cases non-silent #2042

Open
markus2330 opened this Issue Jun 5, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@markus2330
Contributor

markus2330 commented Jun 5, 2018

@ingwinlu said in #2040:

And it will always be the contributors responsibility to make sure all additions are actually tested. Similarly like you would have to modify cmake to include your new files in builds.
Similarly I would like to argue that it is the maintainers responsibility to check if the tests ran where every it is appropriate. A task made significantly harder because of the 'silent removal policy' in some parts of the cmake setup.

Currently we simply conditionally include tests and try to document such conditionally inclusion in doc/todo/TESTING. We do not have much success with this approach (the documentation is often forgotten, sometimes warnings are triggered when something is excluded, sometimes not).

Thus I propose that we implement a remove_test which works similar to remove_plugin. Then we can easily collect all cases where tests are removed by grep and print out a line for every removed test during cmake runs (like for excluded plugins).

What do you think?

@markus2330 markus2330 added the proposal label Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment