Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
pluginprocess.c is not C99 #2061
In the discussions in #2056 we found that pluginprocess.c contains non-C99 code.
EDIT: The second warning seems to be only a aftereffect of the first warning.
referenced this issue
Jun 9, 2018
mkdtemp is probably the best way to create a temporary directory though and i think i had a warning when using mktemp (though i don't remember exactly). It should be defined in stdlib.h present in pluginprocess.c according to https://linux.die.net/man/3/mkdtemp , though its probably newer than C99 i guess. How do we generally deal with such issues?
Looking at it more closely, the problem seems to be trivial. Just add a mkdtemp detection in cmake/Modules/FindPluginprocess.cmake (like you already did with mkfifo and fork).
Btw. "FindPluginprocess.cmake" is a very confusing name, and PLUGINPROCESS_FOUND even more so. I expected it searches for a plugin named "process", not that it searches for the dependences of a library called pluginprocess.
Other options are:
@e1528532 you need the whole man page you linked.
So yes it is in the header, but not made available unless you fulfill those flags.
NOTE.: Those are only compatibilities for glibc, though most libc implementations should have 200809 POSIX compatibility they might have other requirements to enable them or enable it automatically.