New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver: testmod_resolver missing #2226

Open
mpranj opened this Issue Sep 6, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@mpranj
Contributor

mpranj commented Sep 6, 2018

The problem seems to be related to using plugin variants. When plugin compile variants are used, add_plugintest does not seem to build the test. Resolver is one of the affected plugins.

Expected Result

testmod_resolver is built.

Actual Result

testmod_resolver is not built.

System Information

  • Elektra Version: master
@ingwinlu

This comment has been minimized.

Show comment
Hide comment
@ingwinlu

ingwinlu Sep 7, 2018

Contributor

Can you tell us what you passed to cmake so that we can replicate what configuration you were trying to build?

If you did only set some plugins during configuration, please note that there is a set of minimal required plugins needed for elektra to build + run: https://github.com/ElektraInitiative/libelektra/blob/master/doc/COMPILE.md#plugins

Contributor

ingwinlu commented Sep 7, 2018

Can you tell us what you passed to cmake so that we can replicate what configuration you were trying to build?

If you did only set some plugins during configuration, please note that there is a set of minimal required plugins needed for elektra to build + run: https://github.com/ElektraInitiative/libelektra/blob/master/doc/COMPILE.md#plugins

@mpranj

This comment has been minimized.

Show comment
Hide comment
@mpranj

mpranj Sep 7, 2018

Contributor

I can tell you, but it is not relevant. The module resolver is built properly, but the tests are missing.

You can take a look at examples on travis or jenkins. You will not find testmod_resolver anywhere, even though that test exists and is added via add_plugintest ().

The CMakeLists.txt of resolver contains:

add_plugintest (resolver LINK_LIBRARIES ${FURTHER_LIBRARIES} LINK_PLUGIN resolver_fm_hpu_b)

Using add_plugintest () in other plugins with compile variants also fails to add the test to the test suite.

Edit: To clarify: the tests are not skipped. The test binaries are not built at all.

Contributor

mpranj commented Sep 7, 2018

I can tell you, but it is not relevant. The module resolver is built properly, but the tests are missing.

You can take a look at examples on travis or jenkins. You will not find testmod_resolver anywhere, even though that test exists and is added via add_plugintest ().

The CMakeLists.txt of resolver contains:

add_plugintest (resolver LINK_LIBRARIES ${FURTHER_LIBRARIES} LINK_PLUGIN resolver_fm_hpu_b)

Using add_plugintest () in other plugins with compile variants also fails to add the test to the test suite.

Edit: To clarify: the tests are not skipped. The test binaries are not built at all.

@mpranj

This comment has been minimized.

Show comment
Hide comment
@mpranj

mpranj Sep 7, 2018

Contributor

add_plugintest seems to work when linked to the same name:

add_plugintest (crypto_openssl LINK_PLUGIN "crypto_openssl")

In the case of resolver, the names do not match. The test is added for resolver but then linked to resolver_fm_hpu_b. Maybe that has something to do with it.

Contributor

mpranj commented Sep 7, 2018

add_plugintest seems to work when linked to the same name:

add_plugintest (crypto_openssl LINK_PLUGIN "crypto_openssl")

In the case of resolver, the names do not match. The test is added for resolver but then linked to resolver_fm_hpu_b. Maybe that has something to do with it.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Sep 8, 2018

Contributor

Thank you for reporting the problems!
I see two grave problems here:

  1. add_plugintest doing nothing without any error
  2. testmod_resolver not being built and executed
Contributor

markus2330 commented Sep 8, 2018

Thank you for reporting the problems!
I see two grave problems here:

  1. add_plugintest doing nothing without any error
  2. testmod_resolver not being built and executed

@markus2330 markus2330 added this to the 0.8.25 milestone Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment