Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdb export: no -vd #2743

Open
markus2330 opened this issue Jun 2, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@markus2330
Copy link
Contributor

commented Jun 2, 2019

Steps to Reproduce the Problem

I execute an export that does not work:

kdb export -vd ...

Expected Result

That I get an detailed error message.

Actual Result

Sorry, module csvstorage issued the error 117:
invalid number of columns: illegal number of columns (8 - 9) in line 6

which does not contain the additional error information, or:

kdb: invalid option -- 'v'
kdb: invalid option -- 'd'
Sorry, I could not process the given options (see errors above)

Please check for all tools if they actually accept -v and -d and work.

System Information

  • Elektra Version: master
@Piankero

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

This to be honest looks like a bug in the cmdline.cpp because export.cpp correctly uses the command line args.

I debugged it to this section where d and v are treated as illegal option despite explicitly be checked in the case statement.

When I add the following line:

cerr << "Opt:" << opt << endl;

i always receive the following output when taking v or d:

Opt:63

Do you have a hint for me? This seems to be a C related error?

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

It is simply about that not all command-line tools accept -v or -d, although it is now essential with the new error concept.

To add a command-line option to every tool, it must be added in cmdline.cpp line 59 (allOptions).

Then individual vd can be removed from the header files (getShortOptions).

Piankero added a commit to Piankero/libelektra that referenced this issue Jun 6, 2019

markus2330 added a commit that referenced this issue Jun 15, 2019

Merge pull request #2755 from Piankero/cmd-option-for-errormsg-fix
error: Enabled v and d as command line options for all commands #2743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.