Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus Link Checker #2758

Open
kodebach opened this issue Jun 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@kodebach
Copy link
Contributor

commented Jun 7, 2019

The Cirrus link checker task should be run on the merged version of a PR. I.e. it should checkout master, merge the PR branch into master and then run the check. This currently not the case and therefore PRs that are based on a commit of master that contains a broken link (whether originally broken, or only recently) has to be rebased in order for the check to succeed.

For an example of a failing check see #2707. There the link checker complains about the link https://www.fishshell.com, which should be https://fishshell.com. This has been fixed on master, but the link checker will keep complaining, until the PR is rebased, even though in a merge the fixed link from master would be unchanged.

Alternatively, we could run the link checker only on changed lines, but that would probably be more complicated.

@kodebach kodebach added the enhancement label Jun 7, 2019

@kodebach kodebach referenced this issue Jun 7, 2019

Merged

Highlevel codegen updates #2707

4 of 9 tasks complete
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

Thank you very much for reporting this problem!

Is there someone who has time to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.