Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdbCommit #2798

Open
vLesk opened this issue Jun 19, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@vLesk
Copy link

commented Jun 19, 2019

When kdbSet() is called, plugins implementing the commit role need to track their state to distinguish between carrying out that role and carrying out potential other roles (commit and setresolver for the resolver plugin, for example).

To make plugins more modular and to achieve greater flexibility and reusability of plugins, I would like to separate committing into its own function, kdbCommit().

Implementing this function would require the following:

  • Modifying KDB to call the commit function instead of the set function during the commit step
  • Adding a pointer for kdbCommit() to kdbprivate.h
  • Adding support for kdbCommit() to elektraPluginExport
  • Modifying all plugins which carry out the commit role to implement kdbCommit (for existing plugins this could simply be a function which calls the set function again)
  • Modifying pluginprocess to support kdbCommit

Implementing this function has already been proposed in #1274.

@vLesk vLesk added the enhancement label Jun 19, 2019

@vLesk vLesk self-assigned this Jun 19, 2019

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Great description and very good to see activity from you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.