Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behavior of kdbGet() if nothing is to do initially #2810

Open
markus2330 opened this issue Jun 25, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@markus2330
Copy link
Contributor

commented Jun 25, 2019

@kodebach wrote:

As far as I can tell, the NO_UPDATE case is used in two cases:

None of the requested mountpoints have any existing data (i.e. file/block/commit etc doesn't exist). This means the storage plugin call can be replaced by ksNew(0, KS_END).

Here it makes sense to nevertheless call procgetstorage. So maybe we should avoid that this case is NO_UPDATE at all.

@kodebach

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

Here it makes sense to nevertheless call procgetstorage.

Depends on the semantics of procgetstorage. Like I said, if we define that it must return an empty KeySet whenever it is called with an empty KeySet, not calling would be fine.

I don't really see a use case for plugins that lookup some process specific data and store it in the KDB without any dependency on other KDB data. In that case a separate library function returning the data directly makes much more sense and would probably be easier to use.
Such plugins could of course make sense, if their data is then processed further by postgetstorage plugins, but that is currently not possible anyway.

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Yes, it is easily possible that it is useless. I was thinking about applications that only want command-line options but no config files. But currently they would at least need a spec, so the KeySet would not be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.