Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid downloading gtest #2895

Closed
markus2330 opened this issue Aug 18, 2019 · 7 comments

Comments

@markus2330
Copy link
Contributor

commented Aug 18, 2019

  • for configure scripts
  • for Debian Docker files

@markus2330 markus2330 self-assigned this Aug 18, 2019

@markus2330 markus2330 added this to the 0.9.1 milestone Aug 18, 2019

@markus2330 markus2330 changed the title configure- scripts should avoid downloading gtest avoid downloading gtest Aug 18, 2019

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

Seems like also in the Docker files of Debian gtest is downloaded manually.

@sanssecours do you know why we do not use what is included in Debian? Weirdly, libgtest-dev is installed.

Did you try if GTEST_ROOT=/usr works?

@sanssecours

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@sanssecours do you know why we do not use what is included in Debian?

As far as I know, it is the usual reason, being that packages in Debian’s official software repositories are quite old/outdated. I think using the Google Test sources from Debian buster and Debian sid should work though.

Did you try if GTEST_ROOT=/usr works?

Nope.

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

apt install googletest and passing -DGTEST_ROOT="/usr/src/googletest/googletest" to cmake seems to do the trick (for buster).

markus2330 added a commit that referenced this issue Aug 18, 2019
markus2330 added a commit that referenced this issue Aug 19, 2019
markus2330 added a commit that referenced this issue Aug 23, 2019
markus2330 added a commit that referenced this issue Aug 24, 2019
markus2330 added a commit that referenced this issue Aug 31, 2019
@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

On the build server there are problems with using the gtest of Debian:
https://build.libelektra.org/jenkins/blue/organizations/jenkins/libelektra/detail/PR-2889/18/pipeline/313

In file included from /usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:40:0,

                 from /usr/src/googletest/googletest/include/gtest/gtest.h:58,

                 from /usr/src/googletest/googletest/src/gtest_main.cc:32:

/usr/src/googletest/googletest/include/gtest/internal/gtest-port.h:309:5: error: "_MSC_VER" is not defined [-Werror=undef]

 #if _MSC_VER >= 1500

     ^~~~~~~~

/usr/src/googletest/googletest/include/gtest/internal/gtest-port.h:393:5: error: "GTEST_OS_WINDOWS" is not defined [-Werror=undef]

 #if GTEST_OS_WINDOWS

     ^~~~~~~~~~~~~~~~

In file included from /usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:40:0,

                 from /usr/src/googletest/googletest/include/gtest/gtest.h:58,

                 from /usr/src/googletest/googletest/src/gtest_main.cc:32:

/usr/src/googletest/googletest/include/gtest/internal/gtest-port.h:411:5: error: "GTEST_OS_LINUX_ANDROID" is not defined [-Werror=undef]

 #if GTEST_OS_LINUX_ANDROID

     ^~~~~~~~~~~~~~~~~~~~~~

/usr/src/googletest/googletest/include/gtest/internal/gtest-port.h:418:6: error: "GTEST_OS_LINUX_ANDROID" is not defined [-Werror=undef]

So better we leave this issue for now.

@markus2330 markus2330 removed this from the 0.9.1 milestone Aug 31, 2019

markus2330 added a commit that referenced this issue Aug 31, 2019
@sanssecours

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

On the build server there are problems with using the gtest of Debian:
https://build.libelektra.org/jenkins/blue/organizations/jenkins/libelektra/detail/PR-2889/18/pipeline/313

That the build job debian-stretch-full fails, is expected behavior. The Google Tests version in Debian oldstable is just too old to work correctly.

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

Thank you, so we could fix it for the other Debian images?

@sanssecours

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

Thank you, so we could fix it for the other Debian images?

Yes. As far as I know, Debian stable and Debian unstable should offer the correct version of Google Test (v1.8.1 or newer).

markus2330 added a commit that referenced this issue Sep 7, 2019
markus2330 added a commit that referenced this issue Sep 7, 2019
markus2330 added a commit that referenced this issue Sep 8, 2019
markus2330 added a commit that referenced this issue Sep 8, 2019
sanssecours added a commit that referenced this issue Sep 8, 2019
sanssecours added a commit that referenced this issue Sep 8, 2019
sanssecours added a commit to sanssecours/elektra that referenced this issue Sep 11, 2019
sanssecours added a commit to sanssecours/elektra that referenced this issue Sep 11, 2019
markus2330 added a commit that referenced this issue Sep 11, 2019
sanssecours added a commit to sanssecours/elektra that referenced this issue Sep 13, 2019
sanssecours added a commit to sanssecours/elektra that referenced this issue Sep 13, 2019
sanssecours added a commit to sanssecours/elektra that referenced this issue Sep 14, 2019

@markus2330 markus2330 removed their assignment Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.