Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error naming inconsistent #2901

Open
Chemin1 opened this issue Aug 20, 2019 · 4 comments

Comments

@Chemin1
Copy link
Contributor

commented Aug 20, 2019

The names of the errors in the files doc/decisions/error_codes.md and doc/dev/error-categorization.md
do not fit together exactly, but it is not a real problem => low priority label.

C01310 is called Assertion in error_codes and Internal in error-categorization
C01330 is called Plugin is Broken in error_codes and Plugin Misbehaviour in error-categorization

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Thank you for finding out and reporting this problem!

"low priority" is only for something which is okay if it is not fixed at all. But this is definitely not the case here.

@Piankero

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

I fixed it on my branch which I will make a PR once it is ready for it (Piankero@f8fb57a)

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

It is much preferred to have several smaller PRs than a monster PR which takes forever to review and merge.

@Piankero

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

It is fixed among very minor error message improvements in my current PR: #2950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.