Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make elektraPluginOpen/Close public #3028

Open
markus2330 opened this issue Oct 2, 2019 · 2 comments

Comments

@markus2330
Copy link
Contributor

commented Oct 2, 2019

@kodebach said in #3004:

It was present, but not public API. It's also still declared in kdbprivate.h, so shouldn't be public API.

De-facto it is already public API because since quite some time as all tools use it. In particular src/libs/tools/src/plugin.cpp.

The big question is if it should

  1. stay in KDB, or
  2. moved to core (would drop the libkdb dep for invoke).

For header file imho src/include/kdbmodule.h is best (which functions are currently in core afaik).

@markus2330 markus2330 added the proposal label Oct 2, 2019
@kodebach

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

IMO the plugin related stuff should not be in elektra-core. The plugin system doesn't make much sense without the other parts of elektra-kdb.

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

I agree but then we should also move out the modules stuff from core. The downside is that kdb has two deps then.

@markus2330 markus2330 added this to the 0.9.* milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.