Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdb export with `yaml` plugin does not add newline #3311

Closed
Piankero opened this issue Dec 2, 2019 · 6 comments
Labels
bug
Milestone

Comments

@Piankero
Copy link
Contributor

@Piankero Piankero commented Dec 2, 2019

Steps to Reproduce the Problem

I tried to do the asciinema recording with yaml but the missing newline makes it weird

kdb set user/hello/hello/world "Hello World"
kdb export user/hello yaml

Expected Result

Note that elektra $ is the user and $ the delimiter (shell configured that way in docker image)

elektra $ kdb export user/hello yaml
hello:
  world: Hello World!
elektra $ 

Actual Result

elektra $ kdb export user/hello yaml
hello:
  world: Hello Worldelektra $ 

System Information

docker run -it elektra/elektra

Further Log Files and Output

@Piankero Piankero added the bug label Dec 2, 2019
@mpranj

This comment has been minimized.

Copy link
Member

@mpranj mpranj commented Dec 2, 2019

Thank you for reporting! I can reproduce it also without the docker image.

@sanssecours can you take a look please?

@sanssecours sanssecours removed their assignment Dec 2, 2019
@sanssecours

This comment has been minimized.

Copy link
Member

@sanssecours sanssecours commented Dec 2, 2019

@sanssecours can you take a look please?

Sorry, I do not think I have time for that at the moment.

@markus2330

This comment has been minimized.

Copy link
Contributor

@markus2330 markus2330 commented Dec 2, 2019

workaround is something like:

echo `kdb export user/hello yaml`
@Piankero

This comment has been minimized.

Copy link
Contributor Author

@Piankero Piankero commented Dec 2, 2019

Doing this in the asciinema recording would be really weird...

@sanssecours

This comment has been minimized.

Copy link
Member

@sanssecours sanssecours commented Dec 2, 2019

If you want a quick “workaround”, then just replace the line:

with the code

output << data << endl;

.

@mpranj

This comment has been minimized.

Copy link
Member

@mpranj mpranj commented Dec 2, 2019

@sanssecours thank you!

I applied this patch only to the docker image. It's basically only a playground anyway.

Maybe we can fix this properly before the next release.

@mpranj mpranj added this to the 0.9.2 milestone Dec 2, 2019
@mpranj mpranj closed this in 536159d Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.