Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: getConflicts name too general #3318

Open
markus2330 opened this issue Dec 3, 2019 · 4 comments
Open

merge: getConflicts name too general #3318

markus2330 opened this issue Dec 3, 2019 · 4 comments
Assignees

Comments

@markus2330
Copy link
Contributor

@markus2330 markus2330 commented Dec 3, 2019

The API getConflicts needs to be renamed to begin with elektraMerge. E.g. elektraMergeGetConflicts.

@mpranj

This comment has been minimized.

Copy link
Member

@mpranj mpranj commented Dec 3, 2019

Is the elektra prefix not "reserved" for internal usage, or is getConflicts only used internally?

@markus2330

This comment has been minimized.

Copy link
Contributor Author

@markus2330 markus2330 commented Dec 3, 2019

The elektra prefix is normal for all the libs except of the core. But also in the core we have quite some public symbols starting with elektra, e.g. for plugin loading (elektraPluginOpen, ...) Adding the elektra prefix to all functions in the core would be nice but it would be at least as much effort as #3115, so way beyond our capacity.

@markus2330

This comment has been minimized.

Copy link
Contributor Author

@markus2330 markus2330 commented Dec 3, 2019

But for the extra libs (like libmerge) we should take care that everything starts with elektra. Thus this issue.

@Chemin1

This comment has been minimized.

Copy link
Contributor

@Chemin1 Chemin1 commented Dec 5, 2019

Makes sense. I'll get to that as soon as I'm not in bed with fever anymore.

Chemin1 added a commit to Chemin1/libelektra that referenced this issue Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.