Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove entry barriers #3547

Closed
20 tasks
markus2330 opened this issue Nov 1, 2020 · 7 comments
Closed
20 tasks

remove entry barriers #3547

markus2330 opened this issue Nov 1, 2020 · 7 comments

Comments

@markus2330
Copy link
Contributor

markus2330 commented Nov 1, 2020

  • shell recorder link on website, more examples
  • restructure web site (Docu/Dev split does not make sense as it is)
  • intro dev tutorials in README.md of tutorials
  • GETTINGSTARTED for devs? Collection of links to get overview
  • advertise run_env, dev container and run_all_tests via Docker more (TESTING.md?, dev pages)
  • rework main README.md (philosophical stuff later)
  • search for doxygen https://www.doxygen.nl/manual/extsearch.html
  • how to write bindings
  • architecture.md
  • improve big picture
  • cover why writing to system needs root
  • first step tutorial (get/set) with TOML
  • rewrite doc/COMPILE.md to a problem-oriented tutorial (like installing without root)
  • doc/TESTING.md: describe how to run kdb run_all without root
  • advertisement/overview tutorial AsciiNema improvements #2742
  • + video of this tutorial
  • METADATA.ini tutorial
  • Java beginners tutorial with maven
  • run tests without root
  • API docu main page
@markus2330 markus2330 self-assigned this Nov 1, 2020
@robaerd
Copy link
Member

robaerd commented Nov 1, 2020

For me it was the installing of elektra without root.
Installing without root requires a few cmake flags (KDB_DB_SYSTEM, CMAKE_INSTALL_PREFIX, ...) and env variables (LD_LIBRARY_PATH, ..) to be set. Although CMAKE_INSTALL_PREFIX is described in doc/COMPILE, it wasn't obvious to me which cmake flags and envs need to be set for this.
In doc/Testing.md in the section "You have some options to avoid running them as root:", following example cmake invocation is referenced: scripts/configure-home (should btw actually be scripts/dev/configure-home). This example only covers compiling and not installing (CMAKE_INSTALL_PREFIX flag is missing). Since kdb run_all is also described in doc/TESTING.md, it should, at least in my opinion, be also mentioned how to get this working without root.

The steps in doc/tutorials/run_all_tests_with_docker.md - which is actually referenced in doc/TESTING.md - describe how to install it as non-root user, but it is not mentioned that the docker images are run as non-root. So it was in the beginning a little unclear to me why these things needed to be set only here.

I would propose to:

  • add a description that the docker images are run as non-root (and maybe also the reason for this).
  • add a point to doc/INSTALL.md and/or doc/TESTING.md on how to install elektra without root privileges.

@mpranj mpranj added this to the 0.9.* milestone Nov 4, 2020
@markus2330
Copy link
Contributor Author

Thank you very much for this very helpful input!

Although CMAKE_INSTALL_PREFIX is described in doc/COMPILE

Yes, I fully agree, this docu must be rewritten to a style where concrete problems are solved (like installing without root). The sole description of what the flags do is better done within the CMake-cache-variable-docu.

but it is not mentioned that the docker images are run as non-root

I hope you can improve the tutorials about Docker images 💖, you need to adapt them anyway with the changes you make (like removing the need for the Jenkins user).

docker images are run as non-root (and maybe also the reason for this).

Do you mean the reason why they run as non-root? It is best practice to run something with the minimal amount of privileges as possible.

In general: It is good if we do not assume too much knowledge about Docker or Jenkins in our docu, as many people do not have it. So I agree, that such rationale should be given.

@robaerd
Copy link
Member

robaerd commented Nov 6, 2020

I hope you can improve the tutorials about Docker images 💖, you need to adapt them anyway with the changes you make (like removing the need for the Jenkins user).

Yes of course I will improve the tutorials about the Docker images.

@markus2330 markus2330 added the cm2022s for university course label Sep 15, 2021
@markus2330 markus2330 removed their assignment Sep 22, 2021
@marvin-the-parrot marvin-the-parrot self-assigned this Oct 20, 2021
@marvin-the-parrot
Copy link

[FLOSS H1]
Is the documentation label appropriate here? Or is it the case that tutorial are not considered part of the documentation?

All of the tasks in this issue will need comprehensive knowledge of the areas which the tutorials/doc is featuring.

@markus2330 markus2330 changed the title remove entry barriers [FLOSS T3] remove entry barriers Oct 21, 2021
@markus2330
Copy link
Contributor Author

Is the documentation label appropriate here?

Yes, it is fine!

As this is the T3 task (for people that did not find something else), no assignment is necessary.

@markus2330 markus2330 changed the title [FLOSS T3] remove entry barriers remove entry barriers Mar 7, 2022
@markus2330 markus2330 self-assigned this Aug 6, 2022
@flo91 flo91 added floss2022w lang/markdown and removed cm2022s for university course labels Oct 5, 2022
@markus2330 markus2330 removed their assignment Nov 17, 2022
@markus2330 markus2330 changed the title remove entry barriers [FLOSS T3] remove entry barriers Nov 17, 2022
@markus2330 markus2330 changed the title [FLOSS T3] remove entry barriers remove entry barriers Jan 14, 2023
Copy link

github-actions bot commented Feb 2, 2024

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot added the stale label Feb 2, 2024
Copy link

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.0
  
Awaiting triage
Development

No branches or pull requests

5 participants