New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elektra Highlevel API #1605

Open
wants to merge 143 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@domhof
Contributor

domhof commented Sep 13, 2017

Purpose

  • Added support for enums and arrays
  • Improved formatting of generated code
  • Fixed key-normalization (trailing / and /# get removed as well)
  • Fixed code generation for string default values
  • Eliminated some public helper methods (fewer auto completion suggestions in IDEs makes it easier for developers to find the right elektra method)
  • Removed error enums from error specification file (instead we use the raw error code)
  • Improved enum(-array) support
  • Index argument before value in array getters/setters
  • Always require default value
  • Getters/Setters that allow specification of the value type at runtime

TODO:

  • Dokumentation
  • More testing

Checklist

Please only check relevant points.
For docu fixes, spell checking and similar nothing
needs to be checked.

  • commit messages are fine (with references to issues)
  • I ran all tests and everything went fine
  • I added unit tests
  • affected documentation is fixed
  • I added code comments, logging, and assertions
  • meta data is updated (e.g. README.md of plugins)

@markus2330 please review my pull request

@markus2330 markus2330 added this to the 0.8.21 milestone Nov 3, 2017

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Nov 3, 2017

Contributor

I tagged this PR with 0.8.21, it is time to finally get this merged. Can you please finish this PR (docu, tutorial, leftovers).

Also a rebase is required.

Contributor

markus2330 commented Nov 3, 2017

I tagged this PR with 0.8.21, it is time to finally get this merged. Can you please finish this PR (docu, tutorial, leftovers).

Also a rebase is required.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Nov 30, 2017

Contributor

Please avoid merges for such large PRs that create new functionality. Please rebase instead.

Is this ready for review? Please tag accordingly.

Contributor

markus2330 commented Nov 30, 2017

Please avoid merges for such large PRs that create new functionality. Please rebase instead.

Is this ready for review? Please tag accordingly.

@markus2330 markus2330 removed this from the 0.8.21 milestone Dec 17, 2017

@markus2330 markus2330 referenced this pull request Mar 25, 2018

Merged

notification: improved API #1850

9 of 9 tasks complete

@markus2330 markus2330 referenced this pull request Jun 2, 2018

Open

Arrays should contain last index #182

0 of 5 tasks complete

@markus2330 markus2330 referenced this pull request Jun 27, 2018

Closed

Hex Support #1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment