New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins: Fix Issues #1692

Merged
merged 17 commits into from Nov 11, 2017

Conversation

Projects
None yet
2 participants
@sanssecours
Contributor

sanssecours commented Nov 1, 2017

Purpose

This pull request fixes

  1. minor issues in tests that fail, if we use INI as default storage plugin, and
  2. problems in some of the Jenkins build jobs

.

Checklist

  • I checked all commit messages.
  • I ran all tests and everything went fine.
@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 3, 2017

Contributor

Unfortunately I just accidentally pushed to master instead of this branch 😳. Sorry for that. Hopefully commit 9973a3a does not break anything.

Contributor

sanssecours commented Nov 3, 2017

Unfortunately I just accidentally pushed to master instead of this branch 😳. Sorry for that. Hopefully commit 9973a3a does not break anything.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Nov 3, 2017

Contributor

Unfortunately I just accidentally pushed to master instead of this branch 😳. Sorry for that. Hopefully commit 9973a3a does not break anything.

It might break the memleak tests? (Plugins are not being closed?)

But no panic, if it breaks builds, please simply revert the commit (git revert).

Contributor

markus2330 commented Nov 3, 2017

Unfortunately I just accidentally pushed to master instead of this branch 😳. Sorry for that. Hopefully commit 9973a3a does not break anything.

It might break the memleak tests? (Plugins are not being closed?)

But no panic, if it breaks builds, please simply revert the commit (git revert).

@sanssecours sanssecours changed the title from INI: Fix Test Issues to Jenkins: Fix Issues Nov 3, 2017

@markus2330

Thank you for fixing this! Small things I noticed.

Show outdated Hide outdated tests/shell/shell_recorder/mathcheck.esr
Show outdated Hide outdated doc/tutorials/validation.md

sanssecours added some commits Nov 1, 2017

YAML CPP: Use non-cascading keys in MSR example
This way YAML CPP handles all the metadata. If we use cascading keys,
then the example would fail if we use INI as default storage. If you
want to learn more, please check out issue #1687.
Validation: Filter internal metadata of INI plugin
Before this change the tests in the tutorial would not work if we use
INI as default storage.
Math: Use `ni` as storage plugin for test
Before this update the Shell Recorder test would fail, if we use INI as
default storage plugin.
Xerces: Use non-cascading keys in MSR example
This way Xerces handles all the metadata. If we use cascading keys,
then the example would fail if we use INI as default storage. If you
want to learn more, please check out issue #1686.
Xerces: Use regex match in MSR example
Unfortunately the output of the Xerces plugin can differ slightly. This
means we can not match the output exactly against a constant piece of
text.
Shell Recorder: Add tests explicitly
We now add Shell Recorder tests explicitly, since some of them require
certain plugins and do not work if these plugins are not available.

@sanssecours sanssecours closed this Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@ElektraInitiative ElektraInitiative deleted a comment from markus2330 Nov 8, 2017

@sanssecours sanssecours referenced this pull request Nov 8, 2017

Open

Build Server stuff #160

17 of 33 tasks complete

@sanssecours sanssecours reopened this Nov 8, 2017

sanssecours added some commits Nov 8, 2017

Configure XDG: Add `spec` plugin
The test `testkdb_error` does not work correctly if we do not include
the Spec plugin:

    ../tests/kdb/testkdb_error.cpp:177: Failure
    Value of: "110"
    Expected: keyString (ckdb::keyGetMeta (parentKey,
                                           "warnings/#00/number"))
    Which is: "1"

.
@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 9, 2017

Contributor

jenkins build gcc-configure-debian-jessie-minimal please

Contributor

sanssecours commented Nov 9, 2017

jenkins build gcc-configure-debian-jessie-minimal please

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 9, 2017

Contributor

@markus2330 👋 Do you know why application in test testscr_check_external does not retrieve the key system/test/myapp/key in the build job elektra-gcc-configure-debian-jessie-minimal? The behavior is very strange, since all of the following commands print the key without any problem:

/home/jenkins/workspace/workspace/elektra-gcc-configure-debian-jessie-minimal/build/bin/kdb get system/test/myapp/key
/home/jenkins/workspace/workspace/elektra-gcc-configure-debian-jessie-minimal/build/bin/kdb get /test/myapp/key
/usr/local/bin/kdb get system/test/myapp/key
/usr/local/bin/kdb get /test/myapp/key

. The test testscr_check_external also works without any issues on the build job elektra-gcc-configure-debian-stretch-minimal. I was also unable to reproduce the problem on either macOS or Debian Jessie.

Contributor

sanssecours commented Nov 9, 2017

@markus2330 👋 Do you know why application in test testscr_check_external does not retrieve the key system/test/myapp/key in the build job elektra-gcc-configure-debian-jessie-minimal? The behavior is very strange, since all of the following commands print the key without any problem:

/home/jenkins/workspace/workspace/elektra-gcc-configure-debian-jessie-minimal/build/bin/kdb get system/test/myapp/key
/home/jenkins/workspace/workspace/elektra-gcc-configure-debian-jessie-minimal/build/bin/kdb get /test/myapp/key
/usr/local/bin/kdb get system/test/myapp/key
/usr/local/bin/kdb get /test/myapp/key

. The test testscr_check_external also works without any issues on the build job elektra-gcc-configure-debian-stretch-minimal. I was also unable to reproduce the problem on either macOS or Debian Jessie.

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Nov 9, 2017

Contributor

The testscr_check_external should test the installed version. Maybe the installed version (installed by @BernhardDenner for puppet-libelektra) is somehow incompatible? Iirc some time ago the libmeta library was introduced which is now used by the C++ interface. Maybe there is a missing symbol in the application? (I had a similar error once but it was a long time ago.)

Possible fix: update the installed version of Elektra? @BernhardDenner Can you do that? Which version of Elektra are you currently using?

Contributor

markus2330 commented Nov 9, 2017

The testscr_check_external should test the installed version. Maybe the installed version (installed by @BernhardDenner for puppet-libelektra) is somehow incompatible? Iirc some time ago the libmeta library was introduced which is now used by the C++ interface. Maybe there is a missing symbol in the application? (I had a similar error once but it was a long time ago.)

Possible fix: update the installed version of Elektra? @BernhardDenner Can you do that? Which version of Elektra are you currently using?

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 9, 2017

Contributor

jenkins build gcc-configure-xdg please

Contributor

sanssecours commented Nov 9, 2017

jenkins build gcc-configure-xdg please

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 9, 2017

Contributor

jenkins build multiconfig-gcc-stable please

Contributor

sanssecours commented Nov 9, 2017

jenkins build multiconfig-gcc-stable please

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 9, 2017

Contributor

jenkins build gcc-configure-debian-wheezy please

Contributor

sanssecours commented Nov 9, 2017

jenkins build gcc-configure-debian-wheezy please

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 9, 2017

Contributor

jenkins build gcc47-all please

Contributor

sanssecours commented Nov 9, 2017

jenkins build gcc47-all please

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Nov 9, 2017

Contributor

jenkins build ini please

Contributor

sanssecours commented Nov 9, 2017

jenkins build ini please

@markus2330 markus2330 merged commit 0310fa3 into ElektraInitiative:master Nov 11, 2017

13 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
elektra-gcc-configure-debian-intree Build finished. No test results found.
Details
elektra-gcc-configure-debian-log Build finished. No test results found.
Details
elektra-gcc-configure-debian-wheezy Build finished. No test results found.
Details
elektra-gcc-configure-debian-withspace Build finished. No test results found.
Details
elektra-gcc-configure-mingw-w64 Build finished. No test results found.
Details
elektra-gcc-configure-xdg Build finished. No test results found.
Details
elektra-gcc47-all Build finished. No test results found.
Details
elektra-ini-mergerequests Build finished.
Details
elektra-mergerequests-fast Build finished. No test results found.
Details
elektra-mergerequests-stable Build finished. No test results found.
Details
elektra-mergerequests-unstable Build finished.
Details
elektra-multiconfig-gcc-stable Build finished. No test results found.
Details
@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Nov 11, 2017

Contributor

Thank you, great job!

Contributor

markus2330 commented Nov 11, 2017

Thank you, great job!

@sanssecours sanssecours deleted the sanssecours:🐚 branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment