New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group, hosts, passwd, shadow parser #2236

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@tom-wa
Contributor

tom-wa commented Sep 12, 2018

parsers for group, hosts, passwd and shadow, most non-c99 code included in plugins
added full path to parent key as metadata to support calls like ls system/passwd and ls system/passwd/byName like most getent functions need.

some of the code taken from musl, getline/delim taken from freebsd

Basics

Do not describe the purpose here but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains *(my name)*)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@markus2330 please review my pull request

@tom-wa

This comment has been minimized.

Show comment
Hide comment
@tom-wa

tom-wa Sep 12, 2018

Contributor

parsers for services, protocols and {m,f}stab will follow within the next days

Contributor

tom-wa commented Sep 12, 2018

parsers for services, protocols and {m,f}stab will follow within the next days

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Sep 12, 2018

Contributor

Thank you so much for creating the PR!

Contributor

markus2330 commented Sep 12, 2018

Thank you so much for creating the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment