New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port plugin extension #2253

Open
wants to merge 24 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Piankero
Contributor

Piankero commented Sep 26, 2018

Basics

Do not describe the purpose here but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains *(my name)*)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@markus2330 please review my pull request

Piankero added some commits Sep 26, 2018

@Piankero Piankero requested a review from markus2330 Oct 4, 2018

Piankero and others added some commits Oct 4, 2018

Merge remote-tracking branch 'origin/port-plugin-extension' into port…
…-plugin-extension

# Conflicts:
#	src/plugins/network/testmod_network.c
@Piankero

This comment has been minimized.

Show comment
Hide comment
@Piankero

Piankero Oct 5, 2018

Contributor

Ty so much for the reformatting. I tried to configure clion to do IT correctly but some options are not available which you require

Contributor

Piankero commented Oct 5, 2018

Ty so much for the reformatting. I tried to configure clion to do IT correctly but some options are not available which you require

@sanssecours

This comment has been minimized.

Show comment
Hide comment
@sanssecours

sanssecours Oct 5, 2018

Contributor

Ty so much for the reformatting. I tried to configure clion to do IT correctly but some options are not available which you require

I would recommend

  1. to either run clang-format directly on the file you are updating, or
  2. to use the script scripts/reformat-source before you commit your changes

. Another option is to run clang-format as external tool in CLion. There is also a CLion plugin that should be able to reformat code using Clang-Format.

Contributor

sanssecours commented Oct 5, 2018

Ty so much for the reformatting. I tried to configure clion to do IT correctly but some options are not available which you require

I would recommend

  1. to either run clang-format directly on the file you are updating, or
  2. to use the script scripts/reformat-source before you commit your changes

. Another option is to run clang-format as external tool in CLion. There is also a CLion plugin that should be able to reformat code using Clang-Format.

@Piankero

This comment has been minimized.

Show comment
Hide comment
@Piankero

Piankero Oct 5, 2018

Contributor

I don't know whats wrong with the build server but it looks like my build is ok. Please someone take a review of it so we can merge it!

Contributor

Piankero commented Oct 5, 2018

I don't know whats wrong with the build server but it looks like my build is ok. Please someone take a review of it so we can merge it!

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Oct 5, 2018

Contributor

@ingwinlu do you know what is wrong with the build server here?

Contributor

markus2330 commented Oct 5, 2018

@ingwinlu do you know what is wrong with the build server here?

@ingwinlu

This comment has been minimized.

Show comment
Hide comment
@ingwinlu

ingwinlu Oct 6, 2018

Contributor

looks like the connection to the node was lost during build. simply restart the build next time either via jenkins or via the magic phrase and see if this resolves it.

Contributor

ingwinlu commented Oct 6, 2018

looks like the connection to the node was lost during build. simply restart the build next time either via jenkins or via the magic phrase and see if this resolves it.

@markus2330

Please rebase the formatting commits.

Show outdated Hide outdated src/plugins/network/testmod_network.c
Show outdated Hide outdated src/plugins/network/network.c
Show outdated Hide outdated src/plugins/network/network.c
Show outdated Hide outdated src/plugins/network/network.c
Show outdated Hide outdated src/error/specification
@Piankero

This comment has been minimized.

Show comment
Hide comment
@Piankero

Piankero Oct 13, 2018

Contributor

@ingwinlu The build again timed out. Can you restart the job?

@markus2330 Do I have a jenkins account or permission to do that myself?

Contributor

Piankero commented Oct 13, 2018

@ingwinlu The build again timed out. Can you restart the job?

@markus2330 Do I have a jenkins account or permission to do that myself?

@Piankero

This comment has been minimized.

Show comment
Hide comment
@Piankero

Piankero Oct 13, 2018

Contributor

And another timeout in a test it looks like ....

Contributor

Piankero commented Oct 13, 2018

And another timeout in a test it looks like ....

@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Oct 14, 2018

Contributor

Please read doc/BUILDSERVER.md which should make clear how to use the buildserver.

Contributor

markus2330 commented Oct 14, 2018

Please read doc/BUILDSERVER.md which should make clear how to use the buildserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment