New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add dependency from plugin tests to plugins #2266

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@kodebach
Contributor

kodebach commented Oct 10, 2018

Fixes #2265

Basics

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains *(my name)*)

Checklist

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins)

Review

@markus2330 please review my pull request

@markus2330 markus2330 merged commit cfc9912 into ElektraInitiative:master Oct 10, 2018

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markus2330

This comment has been minimized.

Show comment
Hide comment
@markus2330

markus2330 Oct 10, 2018

Contributor

Thank you, very beautiful fix!

Contributor

markus2330 commented Oct 10, 2018

Thank you, very beautiful fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment