New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby plugin: use PluginProcess lib for Ruby VM #2287

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@BernhardDenner
Contributor

BernhardDenner commented Oct 29, 2018

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins)

@markus2330 please review my pull request

@markus2330

This comment has been minimized.

Contributor

markus2330 commented Oct 30, 2018

We use clang >= 6 now, could you please reformat with a newer clang-format?

@markus2330

This comment has been minimized.

Contributor

markus2330 commented Oct 30, 2018

So great to get pluginprocess for ruby! It will make the ruby bindings much more attractive. For the python bindings it works very well (except of a bit slow down for large configurations).

@markus2330

This comment has been minimized.

Contributor

markus2330 commented Nov 30, 2018

Any progress here? Please do not forget to reformat the code with clang 6 or later. And please also rebase (because a release happened in the meantime.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment