Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: check getenv #2340

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@markus2330
Copy link
Contributor

markus2330 commented Jan 26, 2019

Basics

Do not describe the purpose here but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains *(my name)*)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@markus2330 please review my pull request

markus2330 added some commits Jan 26, 2019

tests: remove check getenv
as expected, getenv is not available during tests
@mpranj

This comment has been minimized.

Copy link
Member

mpranj commented Jan 26, 2019

@markus2330 seems like an older build job of this PR on Travis CI is stuck. See https://travis-ci.org/ElektraInitiative/libelektra/builds/484739299

I didn't want to restart/cancel your job without asking, maybe I am mistaken.

@markus2330

This comment has been minimized.

Copy link
Contributor Author

markus2330 commented Jan 26, 2019

Yes, it was an older build! Thank you for the hint. I restarted the Travis build job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.