Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI: Write Tutorial for Java Plugin Development #2552

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mirunix
Copy link

commented Mar 27, 2019

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins and doc/METADATA.md)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@markus2330 please review my pull request

Merging

Please add the "ready to merge" label when the build server and you say
that everything is ready to be merged.

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Very nice that you started it! Commit messages, links, release notes, ... all seems to be perfect. The tutorial itself, however, is quite short at the moment.

How to get started? (How to mount it ...)

@mirunix

This comment has been minimized.

Copy link
Author

commented Mar 27, 2019

Thank you for the feedback. I will continue writing on it.

Merge branches 'issue/2515' and 'master' of https://github.com/miruni…
…x/libelektra into issue/2515

# Conflicts:
#	doc/news/_preparation_next_release.md
@mirunix

This comment has been minimized.

Copy link
Author

commented Apr 2, 2019

Hello @markus2330 , I have a question regarding the info, mount etc. of Java plugins:

According to https://www.libelektra.org/plugins/jni , I should be able to call kdb info on the plugin using classname and classpath, but I am not sure what they actually should be. Could you please make it more clear to me?

Thank you!

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

classname and classpath, but I am not sure what they actually should be

There are some examples how it could be but the exact classpath depends on your system. Ideally (if jna and Elektra's jna binding is installed properly) the classpath should only point to your jar you want to use.

The classname is the classname of the plugin you implemented.

@Piankero did you also use the jni plugin in Windows? Which classpath did you need?

@Piankero

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Unfortunately I cannot help since I do not use Windows for coding.
Furthermore I used the JNA and not JNI. I'm sorry

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@mirunix basically you cannot easily overspecify the "classpath". Simply add everything until all classes are found. If you found out what is needed, please update the docu, so that we also have an example for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.