Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance search #2581

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@hesirui
Copy link
Contributor

commented Apr 3, 2019

I added docsearch as instructed above, but I still an error that it cant find the selector. Despite it is correctly set (relates slimphp/Slim-Website#290). Is this probably an issue with docsearch?

work in progress

hesirui added some commits Apr 3, 2019

@kodebach

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Please add a line to the release notes like the server instructs you to. You should always add this line before opening a PR. Changing it later on, if the content of the PR changes is not a problem.

Apart from that the PR looks good to me.

@hesirui

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@s-pace finally we started to work on #1815! Thanks again for your help there!

Can you maybe help us with the problem @hesirui mentioned above (cant find the selector)?

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

jenkins build homepage please

@s-pace

This comment has been minimized.

Copy link

commented Apr 4, 2019

👋 @markus2330 Great news,

@hesirui can you make sure that the <input/>element already exists with the proper id set when the docsearch() function is call? The issue raised from slimphp/Slim-Website#290 is that they were trying to append the dropdown to an element which does not exist.

I couldn't have a look from a preview. Let me know if you have more details.

hesirui added some commits Apr 6, 2019

@hesirui

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Thank you that was the right hint, docsearch was called before the page was fully initialized. The search is now integrated on the main page, results appear as soon as you type. The old search will still be invoked when pressing the search button.

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

jenkins build homepage please

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

This are great news! Can you please also update the text "Search for configuration snippet..."?

@sanssecours

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

jenkins build homepage please

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

It seems like that this change lets the validation fail:

Value of: cf.isValidated ()
  Actual: true
Expected: false

https://build.libelektra.org/jenkins/job/elektra-homepage/661/console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.