Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixsync #2631

Merged
merged 2 commits into from Apr 14, 2019

Conversation

Projects
None yet
2 participants
@markus2330
Copy link
Contributor

commented Apr 14, 2019

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins and doc/METADATA.md)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@markus2330 please review my pull request

Merging

Please add the "ready to merge" label when the build server and you say
that everything is ready to be merged.

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

@petermax2 can you check if this fixes the fcrypt problem?

@petermax2

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

@petermax2 can you check if this fixes the fcrypt problem?

Your changes fix the problem! 🎉

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Thank you for the quick reply. I forgot to ask if it also still mounts sync in the other cases?

@petermax2

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

Thank you for the quick reply. I forgot to ask if it also still mounts sync in the other cases?

Yes, sir! 😄

root@5fd7ea8f213b:/libelektra/build# kdb mount test.ini user/test crypto_gcrypt "crypto/key=$(elektra-gpg-testkey)" base64 ini
root@5fd7ea8f213b:/libelektra/build# cat /etc/kdb/elektra.ini 
[mountpoints]
user\/test = This is a configuration for a backend, see subkeys for more information
user\/test/config = 
user\/test/config/path = test.ini
user\/test/errorplugins = 
user\/test/errorplugins/#5#resolver_fm_hpu_b#resolver# = 
user\/test/getplugins = 
user\/test/getplugins/#0#resolver = 
user\/test/getplugins/#5#ini#ini# = 
user\/test/getplugins/#8#base64#base64# = 
user\/test/getplugins/#9#crypto_gcrypt#crypto_gcrypt# = 
user\/test/getplugins/#9#crypto_gcrypt#crypto_gcrypt#/config = 
user\/test/mountpoint = user/test
user\/test/setplugins = 
user\/test/setplugins/#0#resolver = 
user\/test/setplugins/#1#crypto_gcrypt = 
user\/test/setplugins/#2#base64 = 
user\/test/setplugins/#5#ini = 
user\/test/setplugins/#6#sync#sync# = 
user\/test/setplugins/#7#resolver = 
[mountpoints/user\/test/getplugins/#9#crypto_gcrypt#crypto_gcrypt#/config/crypto]
key = 6C2CE3467EBF1BF8F5968792575C5FE620FA0712
masterpassword = "hQGMA1dcX+Yg+gcSAQv8DXuni9IkwOT9JZcCLG8GJDB8US2e4SvqKVS9LlDnqzgPhnlAvP0y/beB+v+s45I/lRtG2JnNp8R3dtl90YWKsBdFWA=="
root@5fd7ea8f213b:/libelektra/build# 
@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Basically the output of:

kdb mount a.ecf /tests/something
kdb mountpoint-info /tests/something
kdb ls "system/elektra/mountpoints/\/tests\/something"

@markus2330 markus2330 merged commit 115d932 into master Apr 14, 2019

8 checks passed

LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on PR-2631 at 77.337%
Details
@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Perfect, thank you! You typed faster than me 😄

@markus2330 markus2330 deleted the fixsync branch Apr 14, 2019

@markus2330

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

See also #2636 (follow up issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.