Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error codes implementation #2686

Open
wants to merge 57 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Piankero
Copy link
Contributor

commented May 9, 2019

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins and doc/METADATA.md)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@markus2330 please review my pull request

Merging

Please add the "ready to merge" label when the build server and you say
that everything is ready to be merged.

@Piankero Piankero referenced this pull request May 9, 2019

Closed

New error codes #2589

3 of 9 tasks complete
@markus2330

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

I think we should not merge this except shortly before the release. After the release everyone needs to rebase anyway.

kodebach added some commits May 13, 2019

@sanssecours

This comment has been minimized.

Copy link
Member

commented May 14, 2019

I think we should not merge this except shortly before the release.

In that case I think we can merge #2690 right now.

@markus2330

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Sorry, with "this" I was referring to #2690. The error codes should be first (if finished before doing the release).

@Piankero

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@sanssecours can you help us debug the highlevel test which causes a SEG fault? It seems to be an apple-only bug and as far as I remember you have an apple

@sanssecours

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@sanssecours can you help us debug the highlevel test which causes a SEG fault? It seems to be an apple-only bug and as far as I remember you have an apple

Sorry, but as far as I know the Haskell binding does not compile on my version of macOS (10.14.5) anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.