Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Reformat Code With cmake format 0.5.1 #2690

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@sanssecours
Copy link
Member

commented May 10, 2019

Description

Since cmake format 0.5 changed significant parts of the layout algorithm, this PR contains quite a lot of reformatted code.

This update also changes the number of max sub-arguments, since otherwise cmake-format would produce code that looks like this:

foreach (file
	 ${TESTS})


endforeach (file
	    ${TESTS})

. I also disabled the autosort feature that was enabled by default in cmake format 0.5, since otherwise cmake-format 0.5.1 produces incorrect code.

Note: The chance that this update introduces merge-conflicts is quite high. I think it makes sense to merge this update after PR #2686.

@sanssecours sanssecours added this to the 0.8.27 milestone May 10, 2019

@sanssecours sanssecours force-pushed the sanssecours: branch 6 times, most recently from 1c88d5a to 04b2b19 May 11, 2019

@sanssecours sanssecours force-pushed the sanssecours: branch from 04b2b19 to c834fc2 May 12, 2019

@sanssecours sanssecours referenced this pull request May 14, 2019

Open

Error codes implementation #2686

3 of 9 tasks complete

sanssecours added some commits May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.